Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-13] [$250] Pasting data in chat puts the cursor in the wrong position #40025

Closed
iwiznia opened this issue Apr 10, 2024 · 77 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@iwiznia
Copy link
Contributor

iwiznia commented Apr 10, 2024

Reported here https://expensify.slack.com/archives/C049HHMV9SM/p1712763627228909

Happening on staging but not on prod.

Steps:

  • Copy some text
  • Paste it in the chat box
  • Cursor is at the beginning of the line, but it should be at the end
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0166be7baac5afe84f
  • Upwork Job ID: 1780997931107999744
  • Last Price Increase: 2025-01-14
  • Automatic offers:
    • QichenZhu | Contributor | 105706923
Issue OwnerCurrent Issue Owner: @RachCHopkins
@iwiznia iwiznia added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@iwiznia
Copy link
Contributor Author

iwiznia commented Apr 10, 2024

Seems I can't reproduce it anymore 🤷

@iwiznia iwiznia closed this as completed Apr 10, 2024
@Julesssss
Copy link
Contributor

Thank fuck for that

@lanitochka17
Copy link

Issue is still reproducible on the latest build 1.4.63-0
mWeb/Chrome

cursorled.mp4

@lanitochka17 lanitochka17 reopened this Apr 18, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Apr 18, 2024

Hmm I think this is different, it only happens when we paste the name of the emoji like :joy: and it is happening in prod as well, so removing the label and opening it up for proposals.

@rlinoz rlinoz added Help Wanted Apply this label when an issue is open to proposals by contributors External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment labels Apr 18, 2024
@melvin-bot melvin-bot bot changed the title Pasting data in chat puts the cursor in the wrong position [$250] Pasting data in chat puts the cursor in the wrong position Apr 18, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0166be7baac5afe84f

Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

@arsen037
Copy link

I ever experienced this issue and solved it. I did use Input Method Service and change the cursor position in Android.
Same way in iOS solved the problem.

Copy link

melvin-bot bot commented Apr 18, 2024

📣 @arsen037! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@arsen037
Copy link

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/narekg2

Copy link

melvin-bot bot commented Jan 27, 2025

@rlinoz, @jjcoffee, @RachCHopkins, @QichenZhu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@jjcoffee
Copy link
Contributor

We're holding on #55509 to get merged first.

@melvin-bot melvin-bot bot removed the Overdue label Jan 27, 2025
@rlinoz
Copy link
Contributor

rlinoz commented Jan 30, 2025

@QichenZhu any updates on this one?

@melvin-bot melvin-bot bot added the Overdue label Jan 30, 2025
@QichenZhu
Copy link
Contributor

@rlinoz Sorry for the delay, I wasn’t feeling well the past two days. I’ll get to this by Friday.

Copy link

melvin-bot bot commented Jan 31, 2025

@rlinoz, @jjcoffee, @RachCHopkins, @QichenZhu Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Jan 31, 2025
@jjcoffee
Copy link
Contributor

PR is under review.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 6, 2025
@melvin-bot melvin-bot bot changed the title [$250] Pasting data in chat puts the cursor in the wrong position [Due for payment 2025-02-13] [$250] Pasting data in chat puts the cursor in the wrong position Feb 6, 2025
Copy link

melvin-bot bot commented Feb 6, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 6, 2025
Copy link

melvin-bot bot commented Feb 6, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.94-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-13. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Feb 6, 2025

@jjcoffee @RachCHopkins @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@jjcoffee
Copy link
Contributor

jjcoffee commented Feb 13, 2025

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: https://github.com/Expensify/react-native-live-markdown/pull/450/files#r1954219567

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: N/A

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Precondition:

  • Android Chrome with Samsung keyboard

Test:

  1. Copy some text, e.g. "aaa" and go to any chat.
  2. Use the device keyboard to input "aaa"
  3. Send the message.
  4. Right click or long press the Composer to show the context menu and click Paste.
  5. Verify that the copied text pastes into the Composer and the caret is at the end.

Do we agree 👍 or 👎

@RachCHopkins
Copy link
Contributor

Payment Summary:

  • Contributor: @QichenZhu to be paid $250 via Upwork
  • Contributor+: @jjcoffee to be paid $250 via NewDot manual request

Upwork job here

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2025
@RachCHopkins
Copy link
Contributor

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
Status: Done
Development

No branches or pull requests