[HOLD Swift fix] Update to react-native-nitro-sqlite

[mountiny]

As discussed in this thread, the react-native-quick-sqlite package is being migrated to react-native-nitro-sqlite and the original place where we are pulling the library from was deprecated leading to issues when running the native App.

Solution

Switch to the react-native-nitro-sqlite library pointing to the old code and the migrate to the new version of react-native-nitro-sqlite cc @chrispader

Issue Owner

Current Issue Owner: @chrispader

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

Handling it

[mountiny]

PR cped

[DylanDylann]

@dominictb is working on another PR, I am not sure if they also get paid on this issue or on another issue

[Christinadobrzyn]

Ah thanks @DylanDylann!

Hum, it looks like Expensify/react-native-onyx#602 is still being worked on but #53049 can be paid.

@mountiny do you think it would be best for us to create a separate payment for Expensify/react-native-onyx#602 or keep them together?

[mountiny]

@Christinadobrzyn Whatever works for you, you can pay @DylanDylann now I think and we can unassign them

[melvin-bot]

@chrispader @mountiny @Christinadobrzyn @shubham1206agra @DylanDylann @dominictb this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@chrispader, @mountiny, @Christinadobrzyn, @shubham1206agra, @DylanDylann, @dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

Sounds good -

Payment for PR - #53049

Contributor: @DylanDylann paid $250 via Upwork (https://www.upwork.com/nx/wm/offer/105260846)

@DylanDylann can you accept this offer? TY

[mountiny]

@chrispader What is your ETA for other changes?

[Christinadobrzyn]

Just a heads up that I'm going to be ooo Dec 12 - 13th. Back on Monday 16th. I'm not going to assign this to a BZ teammate but if anything is urgent, please reach out to the team for a volunteer.

[Christinadobrzyn]

@chrispader can you provide an update when you have a moment (re)? TY!

[chrispader]

Yes, sorry for the delay. I've been trying to set up my bank account and wallet on my testing account, but @mountiny told me that this is only possible for US people.

I therefore won't be able to reproduce this issue in the app. I'm trying to repro this another way.

Other than that, i think the current PRs are ready and working.

Edit: I'll have to setup VBBA and reimbursement on my account. Will continue testing tmrw

[Christinadobrzyn]

Hi @chrispader please let us know if you have an update or need any help with testing!

[melvin-bot]

@chrispader, @mountiny, @Christinadobrzyn, @shubham1206agra, @DylanDylann, @dominictb Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@chrispader, @mountiny, @Christinadobrzyn, @shubham1206agra, @DylanDylann, @dominictb Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@chrispader, @mountiny, @Christinadobrzyn, @shubham1206agra, @DylanDylann, @dominictb 10 days overdue. Is anyone even seeing these? Hello?

[chrispader]

Was waiting for more reproduction steps by the C+. The previous issue is not reproducible anymore. Now going to investigate another issue...

[Christinadobrzyn]

Thanks, @chrispader - sorry, can you clarify which issue you need more reproduction steps for? Thanks!

Just a heads up that I'm going to be ooo until Dec 30th. I'm not going to assign this to a BZ teammate but if anything is urgent, please reach out to the team for a volunteer.

[chrispader]

Thanks, @chrispader - sorry, can you clarify which issue you need more reproduction steps for? Thanks!

So the current problem is that there is an issue in Swift which is shipped with the latest Xcode 16.2 version.

We cannot build Nitro and NitroSQLite with Xcode 16.2, and therefore need to either force downgrading to Xcode 16.1 or increase the minimum iOS deployment target (for simulators).

I explained this further here: #53149 (comment)

[mountiny]

Holding for the Swift fix. @chrispader is there something we could track this on? Some issue/ discussion in swift forum so we know if the fix is getting in? I assume this is quite important for Nitro

[chrispader]

Holding for the Swift fix. @chrispader is there something we could track this on? Some issue/ discussion in swift forum so we know if the fix is getting in? I assume this is quite important for Nitro

@mountiny The fix has already been merged into Swift here. We now just have to wait for a new Xcode version that ships this updated version of Swift, which might take some time though :/