Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use reports for isArchived Check #54590

Open
srikarparsi opened this issue Dec 26, 2024 · 10 comments
Open

Don't use reports for isArchived Check #54590

srikarparsi opened this issue Dec 26, 2024 · 10 comments
Assignees
Labels
Daily KSv2

Comments

@srikarparsi
Copy link
Contributor

As a part of the migration to start using the reportNameValuePairs Onyx collection in App, we migrated the private_isArchived key from the reports collection to the reportNameValuePairs collection.

To finish this migration, we need to stop reading from the reports collection here and instead use the reportNameValuePairs collection

@nkdengineer
Copy link
Contributor

@srikarparsi Can contributor work on this?

@srikarparsi
Copy link
Contributor Author

Hey @nkdengineer, actually have a WIP PR here that I've been working on on the side.

@melvin-bot melvin-bot bot added the Overdue label Dec 30, 2024
Copy link

melvin-bot bot commented Dec 30, 2024

@srikarparsi, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Jan 1, 2025

@srikarparsi, @allgandalf Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Jan 3, 2025

@srikarparsi, @allgandalf 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@srikarparsi
Copy link
Contributor Author

Working on this here

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 5, 2025
Copy link

melvin-bot bot commented Jan 9, 2025

@srikarparsi, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Jan 13, 2025

@srikarparsi, @allgandalf 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Jan 15, 2025

@srikarparsi, @allgandalf Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@srikarparsi
Copy link
Contributor Author

Almost done, hopefully can be merged tomorrow

@melvin-bot melvin-bot bot removed the Overdue label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants