[$50] Android - Workspace - The Next button overlaps with the device navigation bar

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.79-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5383034
Issue reported by: Applause Internal Team
Device used: Samsung S23FE/ Android 14
App Component: Workspace Settings

Action Performed:

Preconditions:
The user is an admin of a workspace.
The device navigation bar is displayed instead of gestures.

Steps:

1. Navigate to More features on workspace settings
2. Enable Company Cards
3. Navigate to Company Cards
4. Tap on Add Company Cards
5. Tap on American Express
6. Tap on the next button
7. Select the option for "Corporate Cards"
8. Tap on the next button

Expected Result:

The "Next" button should be displayed above the device navigation bar.

Actual Result:

The "Next" button is displayed behind the device navigation bar.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021873112388502156931
• Upwork Job ID: 1873112388502156931
• Last Price Increase: 2024-12-28

Issue Owner

Current Issue Owner: @abdulrahuman5196

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

while adding company card, on card instruction page, we have next button going under device navigation bar

What is the root cause of that problem?

We are applying safeAreaPaddingBottomStyle to the ScrollView component in CardInstructionsStep.
Thats why it takes full height and as button is at end, it goes behind navigation bar.

What changes do you think we should make in order to solve the problem?

We pass the safeAreaPaddingBottomStyle in contentContainerStyle array to ScrollView like following -

 <ScreenWrapper
            testID={CardInstructionsStep.displayName}
            includeSafeAreaPaddingBottom={false}
            shouldEnablePickerAvoiding={false}
            shouldEnableMaxHeight
        >
            {({ safeAreaPaddingBottomStyle }) => (
                <>
                    ...
                    <ScrollView
                        style={[styles.pt0, styles.trialBannerBackgroundColor]}
                        contentContainerStyle={[safeAreaPaddingBottomStyle, styles.flexGrow1]}
                    >
                     ...
                </>
            )}

        </ScreenWrapper>

We have followed same pattern at multiple places and it works as expected.

Example -

App/src/pages/FlagCommentPage.tsx

Lines 133 to 146 in 9412d21

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	testID={FlagCommentPage.displayName}
	>
	{({safeAreaPaddingBottomStyle}) => (
	<FullPageNotFoundView shouldShow={!ReportUtils.shouldShowFlagComment(reportAction, report)}>
	<HeaderWithBackButton
	title={translate('reportActionContextMenu.flagAsOffensive')}
	onBackButtonPress={() => Navigation.goBack(route.params.backTo)}
	/>
	<ScrollView
	contentContainerStyle={safeAreaPaddingBottomStyle}
	style={styles.settingsPageBackground}
	>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

[huult]

Edited by proposal-police: This proposal was edited at 2024-12-28 15:21:44 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Next button overlaps with the device navigation bar

What is the root cause of that problem?

This occurs because we have disabled includeSafeAreaPaddingBottom by setting it to false here.

App/src/pages/workspace/companyCards/addNew/CardInstructionsStep.tsx

Line 88 in 1ab06c4

includeSafeAreaPaddingBottom={false}

Same with #53650

What changes do you think we should make in order to solve the problem?

To resolve this issue we just need remove includeSafeAreaPaddingBottom here to enable safe area padding

After we remove includeSafeAreaPaddingBottom to enable safe area padding, the result is:

• 

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

I don’t think we need a test here since this is a UI bug

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021873112388502156931

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

Upwork job price has been updated to $50

[mountiny]

making this external for $50 as its very minor

@abdulrahuman5196 can you please review the proposals

[kirillzyusko]

I like the proposal from @huult - this is the current appraoch in the app (i. e. we don't subscribe to context via inline functions and it's something that we actively use).

The only one thing that concerns me is that the button (Next) seems to be very high (at least for me). Just make sure it has the same position as on other screens and we're good to go!

[huult]

@kirillzyusko Yes, I will test it on other screens to ensure the same position

[abdulrahuman5196]

@mountiny I think we can handle similar issues here #53650 instead of handling it separately.