-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2025-02-06] [HOLD for payment 2025-02-05] [$250] Chat - Bold markdown gets triplicated when used as a second markdown in an emoji. #55115
Comments
Triggered auto assignment to @abekkala ( |
Triggered auto assignment to @grgia ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@mountiny Please reopen this issue. |
Is this issue still reproducible? Markdown syntaxes seem to work fine on the latest staging and dev Screen.Recording.2025-01-13.at.10.37.20.mov |
Oh I see, it occurs on the latest version of the Live Markdown |
Hello, since the problem is serious and might be blocking another deploy, we decided to fix it by disabling splitting ranges on emojis on the web. Afterward, we will focus on enhancing the web parser to make it more bug-proof and flexible for range lengths. The more detailed info you can find in this Slack thread. Disabling this functionality on the web platform doesn't change anything because emojis styles can be fixed using CSS styles |
Here is the PR with the fix that removes emoji splitting logic from the web and replaces it with the CSS fix. @shubham1206agra Thank you for the PR, however, there are many more cases where text is duplicated. My PR works around this so we can unblock some PRs and bump the library in the Live Markdown without generating deploy blockers. Nevertheless, I encourage you to try to fix this issue by changing web parser logic and handling HTML structure building edge cases for situations where we have to split ranges on emojis but there are also styles like
This is something that we will be working on in the future so if only you are interested feel free to submit the PR with the solution :D |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
@mountiny Maybe I am the best person to review the bump PR as I have the best context here. |
Hello, here is the PR to NewDot and here is the PR to OldDot (we needed to update patch file name). Once both are approved we will merge them at the same time to not break anything (first NewDot and then OldDot) |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-02-05. 🎊 For reference, here are some details about the assignees on this issue:
|
@sobitneupane @abekkala @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.91-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-02-06. 🎊 For reference, here are some details about the assignees on this issue:
|
@sobitneupane @abekkala @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
PAYMENT SUMMARY FOR FEB 06
|
Payment Summary
BugZero Checklist (@abekkala)
|
@sobitneupane can you complete checklist please? |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.84-0
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Other
Action Performed:
Expected Result:
Bold markdown should be displayed only once when used as a second markdown on an emoji.
Actual Result:
Bold markdown gets triplicated when used as second markdown in an emoji message.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6711634_1736579064916.Bold.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @abekkalaThe text was updated successfully, but these errors were encountered: