Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-02-06] [HOLD for payment 2025-02-05] [$250] Chat - Bold markdown gets triplicated when used as a second markdown in an emoji. #55115

Open
3 of 8 tasks
IuliiaHerets opened this issue Jan 11, 2025 · 21 comments · Fixed by #55127
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Jan 11, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.84-0
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Other

Action Performed:

  1. Open the staging.new.expensify.com website.
  2. Open any chat.
  3. Compose a message with two markdowns, being the second one "Bold" and an emoji. Example: :smile
  4. Check the bold markdown behaviour with this action.

Expected Result:

Bold markdown should be displayed only once when used as a second markdown on an emoji.

Actual Result:

Bold markdown gets triplicated when used as second markdown in an emoji message.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6711634_1736579064916.Bold.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021881676503226665257
  • Upwork Job ID: 1881676503226665257
  • Last Price Increase: 2025-01-21
Issue OwnerCurrent Issue Owner: @abekkala
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Jan 11, 2025
Copy link

melvin-bot bot commented Jan 11, 2025

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 11, 2025

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 11, 2025
Copy link

melvin-bot bot commented Jan 11, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 11, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@shubham1206agra
Copy link
Contributor

@mountiny Please reopen this issue.

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Jan 11, 2025
@mountiny mountiny reopened this Jan 11, 2025
@Skalakid
Copy link
Contributor

Is this issue still reproducible? Markdown syntaxes seem to work fine on the latest staging and dev

Screen.Recording.2025-01-13.at.10.37.20.mov

@Skalakid
Copy link
Contributor

Oh I see, it occurs on the latest version of the Live Markdown

@Skalakid
Copy link
Contributor

Skalakid commented Jan 15, 2025

Hello, since the problem is serious and might be blocking another deploy, we decided to fix it by disabling splitting ranges on emojis on the web. Afterward, we will focus on enhancing the web parser to make it more bug-proof and flexible for range lengths. The more detailed info you can find in this Slack thread. Disabling this functionality on the web platform doesn't change anything because emojis styles can be fixed using CSS styles

@Skalakid
Copy link
Contributor

Skalakid commented Jan 15, 2025

Here is the PR with the fix that removes emoji splitting logic from the web and replaces it with the CSS fix. @shubham1206agra Thank you for the PR, however, there are many more cases where text is duplicated. My PR works around this so we can unblock some PRs and bump the library in the Live Markdown without generating deploy blockers.

Nevertheless, I encourage you to try to fix this issue by changing web parser logic and handling HTML structure building edge cases for situations where we have to split ranges on emojis but there are also styles like bold and inline code block. Here are some desired outcomes:

  • _*hello😁world*_ should be rendered in the HTML as _*hello*_😁_*world*_
  • _*'inline😁code'*_ should be rendered in the HTML as _*'inline'*_'😁'_*'code'*_ (replace ' with `)

This is something that we will be working on in the future so if only you are interested feel free to submit the PR with the solution :D

Copy link

melvin-bot bot commented Jan 21, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 21, 2025
@shubham1206agra
Copy link
Contributor

@mountiny Maybe I am the best person to review the bump PR as I have the best context here.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jan 21, 2025
@Skalakid
Copy link
Contributor

Hello, here is the PR to NewDot and here is the PR to OldDot (we needed to update patch file name). Once both are approved we will merge them at the same time to not break anything (first NewDot and then OldDot)

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 28, 2025
@melvin-bot melvin-bot bot changed the title [$250] Chat - Bold markdown gets triplicated when used as a second markdown in an emoji. [HOLD for payment 2025-02-05] [$250] Chat - Bold markdown gets triplicated when used as a second markdown in an emoji. Jan 29, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 29, 2025
Copy link

melvin-bot bot commented Jan 29, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 29, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @sobitneupane requires payment through NewDot Manual Requests
  • @Skalakid does not require payment (Contractor)

Copy link

melvin-bot bot commented Jan 29, 2025

@sobitneupane @abekkala @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 30, 2025
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2025-02-05] [$250] Chat - Bold markdown gets triplicated when used as a second markdown in an emoji. [HOLD for payment 2025-02-06] [HOLD for payment 2025-02-05] [$250] Chat - Bold markdown gets triplicated when used as a second markdown in an emoji. Jan 30, 2025
Copy link

melvin-bot bot commented Jan 30, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.91-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-06. 🎊

For reference, here are some details about the assignees on this issue:

  • @sobitneupane requires payment through NewDot Manual Requests
  • @Skalakid does not require payment (Contractor)

Copy link

melvin-bot bot commented Jan 30, 2025

@sobitneupane @abekkala @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@abekkala
Copy link
Contributor

abekkala commented Jan 30, 2025

PAYMENT SUMMARY FOR FEB 06

  • Fix: @Skalakid - not payment needed (contractor)
  • PR Review: @sobitneupane [$250, if no regressions] payment via NewDot
    Please complete the checklist above.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 4, 2025
Copy link

melvin-bot bot commented Feb 6, 2025

Payment Summary

Upwork Job

  • Reviewer: @sobitneupane owed $250 via NewDot
  • Contributor: @Skalakid is from an agency-contributor and not due payment

BugZero Checklist (@abekkala)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1881676503226665257/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Feb 6, 2025
@abekkala
Copy link
Contributor

abekkala commented Feb 6, 2025

@sobitneupane can you complete checklist please?

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants