Don't automatically unpause focus trap #54593

bernhardoj · 2024-12-27T06:06:07Z

Explanation of Change

Upstream PR: focus-trap/focus-trap#1335

Fixed Issues

$ #54335
PROPOSAL: #54335 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite: have a workspace

Open the workspace profile page
Press Share button
Press the #admins text link. This will open the admins room
Focus on the composer
Verify the composer has a green outline
Send any message (if there is no message yet)
Right-click/long-press the message and choose Edit comment
Verify the edit composer has a green outline
Moves the cursor to the start of the text
Type anything
Verify the cursor doesn't go to the end of the text

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ioa.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2024-12-27T06:06:13Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2024-12-28T21:27:59Z

What is your eta to test this @allroundexperts? thanks!

github-actions · 2024-12-28T21:28:18Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2024-12-28T21:52:33Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/54593/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/54593/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/54593/NewExpensify.dmg	https://54593.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

allroundexperts · 2024-12-29T20:36:44Z

Will review this today @mountiny

allroundexperts · 2024-12-29T20:36:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-30.at.2.54.14.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-12-30.at.2.27.11.PM.mov

iOS: Native

Screen.Recording.2024-12-30.at.2.24.31.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-12-30.at.2.23.00.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-30.at.2.13.07.PM.mov

MacOS: Desktop

Screen.Recording.2024-12-30.at.2.20.36.PM.mov

allroundexperts · 2024-12-30T09:59:52Z

@bernhardoj On Android web, pressing the keyboard Enter key results in a new line but the cursor shifts to the start of the input.

Screen.Recording.2024-12-30.at.2.28.33.PM.mov

bernhardoj · 2024-12-30T10:39:11Z

I can't repro it on this PR. Maybe it's a different issue.

android.mweb.mp4

allroundexperts · 2024-12-30T14:33:31Z

@bernhardoj I tested again on the build https://54593.pr-testing.expensify.com

As you can see, there are still issues.

Screen.Recording.2024-12-30.at.7.32.43.PM.mov

bernhardoj · 2024-12-31T04:39:35Z

Same, still can't repro it. The composer has a green outline, so the focus works correctly.

android.mp4

Can you try disabling all focus traps and see if the issue still happens?

bernhardoj added 2 commits December 27, 2024 12:50

don't unpause focus trap when deactivated

93faf50

don't unpause focus trap when deactivated

e945784

bernhardoj requested a review from a team as a code owner December 27, 2024 06:06

melvin-bot bot requested a review from allroundexperts December 27, 2024 06:06

melvin-bot bot removed the request for review from a team December 27, 2024 06:06

mountiny assigned bernhardoj Dec 28, 2024

mountiny added the Ready To Build label Dec 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't automatically unpause focus trap #54593

Don't automatically unpause focus trap #54593

bernhardoj commented Dec 27, 2024 •

edited

Loading

melvin-bot bot commented Dec 27, 2024

mountiny commented Dec 28, 2024

github-actions bot commented Dec 28, 2024

github-actions bot commented Dec 28, 2024

allroundexperts commented Dec 29, 2024

allroundexperts commented Dec 29, 2024 •

edited

Loading

allroundexperts commented Dec 30, 2024

bernhardoj commented Dec 30, 2024

allroundexperts commented Dec 30, 2024

bernhardoj commented Dec 31, 2024 •

edited

Loading

Don't automatically unpause focus trap #54593

Are you sure you want to change the base?

Don't automatically unpause focus trap #54593

Conversation

bernhardoj commented Dec 27, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 27, 2024

mountiny commented Dec 28, 2024

github-actions bot commented Dec 28, 2024

github-actions bot commented Dec 28, 2024

allroundexperts commented Dec 29, 2024

allroundexperts commented Dec 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Dec 30, 2024

bernhardoj commented Dec 30, 2024

allroundexperts commented Dec 30, 2024

bernhardoj commented Dec 31, 2024 • edited Loading

bernhardoj commented Dec 27, 2024 •

edited

Loading

allroundexperts commented Dec 29, 2024 •

edited

Loading

bernhardoj commented Dec 31, 2024 •

edited

Loading