Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non ASCII characters in comments cause issues on python 2.7.12 #1029

Closed
abattye opened this issue Oct 11, 2017 · 3 comments
Closed

Non ASCII characters in comments cause issues on python 2.7.12 #1029

abattye opened this issue Oct 11, 2017 · 3 comments
Assignees

Comments

@abattye
Copy link

abattye commented Oct 11, 2017

The agent (and maybe also driver) fails to run due to the presence of the non ascii ® character in comments.

The error generated is (for example) :

SyntaxError: Non-ASCII character '\xc2' in file /var/lib/openstack/src/f5-openstack-agent/f5_openstack_agent/lbaasv2/drivers/bigip/agent_manager.py on line 238, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details

Please either remove these characters or specify an encoding as per pep-0263

@richbrowne
Copy link
Contributor

These characters were pulled as part of a previous commit. I could find no instances of non-ASCII characters remaining.

@mattgreene
Copy link
Contributor

Recommend adding a pipeline check in travis (script or pep enforcement) to block future changes from introducing these characters.

@mattgreene
Copy link
Contributor

Filed #1057 as enhancement to prevent future problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants