Simplified base class design for documenting aberrations #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… replaced all locations where NXaperture_em was used for NXaperture
19 tasks
…more meaty base class NXimage_set, the partner in crime for NXspectrum_set
lukaspie
approved these changes
Jun 28, 2024
…asses Fused NXimage_r_set, NXimage_c_set, NXimage_r_set_diff into a single …
|
NXcomponent as a base class in NXinstrument or likewise as a proposal for a refactoring from which NXaperture and many other NIAC traditional base classes could inherit from I support, however, there is much legacy with this, also using NXfabrication through would be useful but there is so much legacy fixing required for maybe that too little benefit, this is really one of the examples which shows me why not postponing the implementation of good suggestion is useful, anyhow I think that branch can be merged and with it this PR closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.