Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 First two TRs not affected by bandpass filter #2152

Open
10 of 15 tasks
shnizzedy opened this issue Sep 17, 2024 · 0 comments
Open
10 of 15 tasks

🐛 First two TRs not affected by bandpass filter #2152

shnizzedy opened this issue Sep 17, 2024 · 0 comments
Assignees

Comments

@shnizzedy
Copy link
Member

shnizzedy commented Sep 17, 2024

Reported by Shinwon Park

Describe the bug

Two TRs are excluded from bandpass filters when 1D files have 3-row headers.

if line.startswith('#') or isinstance(line[0], str):

evaluates to True for any lines when they're read in as strings, so
for i in range(5):
line = f.readline()
if line.startswith('#') or isinstance(line[0], str):
header.append(line)
is grabbing the first 5 lines as header regardless of their contents.

Preconfig

  • default
  • abcd-options
  • anat-only
  • blank
  • ccs-options
  • fmriprep-options
  • fx-options
  • monkey
  • monkey-ABCD
  • ndmg
  • nhp-macaque
  • preproc
  • rbc-options
  • rodent

Custom pipeline configuration

Anything with bandpass regressors

Expected behavior

All TRs are included in bandpass filter

Acceptance criteria

  • All TRs are included in bandpass filter

C-PAC version

v1.8.6, v1.8.7

Container platform

Docker, Singularity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

No branches or pull requests

1 participant