-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected Hanabi, new Dockerfile, python 3.10 and other fixes #71
Conversation
Hanabi obl pytorch
It says 10k additions which is crazy but it's because we're adding a ground-truth file for testing hanabi which contains 10k game scores. |
Have you tested that the PPO code runs with the new requirements for other environments? Otherwise this could break a lot of stuff. |
I've checked that all the scripts run and I collected results for both IPPO and MAPPO with rnns in mpe and smax here: https://wandb.ai/mttga/jaxmarl_pull_request_71?nw=nwusermttga Let me know if you want to see other results |
LGTM. Thanks very much for all this hard work this is awesome 😄 . Feel free to merge when you are ready. |
This merge contains the following updates:
jnp.concat
(instead ofjnp.concatenate
) insmax
, which causes problems when using the NVIDIA image.