FLAMEGPU_BUILD_PYTHON_PATCHELF defaults to ON

[ptheywood]

I appear to have made FLAMEGPU_BUILD_PYTHON_PATCHELF default to ON at some point

FLAMEGPU2/swig/python/CMakeLists.txt

Line 18 in 03e71c9

option(FLAMEGPU_BUILD_PYTHON_PATCHELF "Use PATCHELF to remove a runtime dependency on libnvrtc-builtins.so" ON)

and if patchelf is not found then a fatal error is emitted rather than a simple warning / falling back to not being enabled.

FLAMEGPU2/swig/python/CMakeLists.txt

Lines 379 to 391 in 03e71c9

	if (FLAMEGPU_BUILD_PYTHON_PATCHELF AND NOT WIN32)
	find_program(PATCHELF patchelf)
	if (PATCHELF)
	add_custom_command(
	TARGET ${PYTHON_SWIG_TARGET_NAME}
	POST_BUILD
	COMMAND patchelf --remove-needed libnvrtc-builtins.so.${CUDAToolkit_VERSION_MAJOR}.${CUDAToolkit_VERSION_MINOR} $<TARGET_FILE_NAME:${PYTHON_SWIG_TARGET_NAME}>
	COMMENT "Patching $<TARGET_FILE_NAME:${PYTHON_SWIG_TARGET_NAME}> ELF to not depend upon libnvrtc-builtins.so.${CUDAToolkit_VERSION_MAJOR}.${CUDAToolkit_VERSION_MINOR}"
	)
	else()
	message(FATAL_ERROR "patchelf could not be found, but is required by FLAMEGPU_BUILD_PYTHON_PATCHELF=ON. Please ensure that patchelf is installed and on your path.")
	endif()
	endif()

Defaulting to off is probably the simplest improvement, as CI should be opting into this.

Should probably document the option too.