Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When RobotGamePieceState is NoGamePiece but bottom, middle or top button is pressed #96

Open
ErikCald opened this issue Mar 22, 2023 · 0 comments
Assignees
Labels
NorthBay Tasks for north bay priority:medium Medium priority

Comments

@ErikCald
Copy link
Collaborator

ErikCald commented Mar 22, 2023

Currently when the RobotGamePieceState == NoGamePiece, and the bottom, middle or top button is pressed, the arm will go the pickup location.

I'm starting to think this is a bad idea. Whenever the X button is pressed, it will go to the pickup location as long as we are not holding any gamepiece and it will rumble once it get's to the pickup location.

None of this functionality happens if you go to the pickup location using one of the other buttons.

Also, if you click X, then click A, then click X, each press will be a new ArmCommand which will try to go back the first waypoint.
If you just click X over and over again, it will only try to go the first waypoint once.

So I think the ArmSelectorCommand should do nothing if RobotGamePieceState == NoGamePiece instead of going to the pickup location. m_ArmCommand should be set to an InstantCommand to avoid problems.

@ErikCald ErikCald added priority:medium Medium priority NorthBay Tasks for north bay labels Mar 22, 2023
@ErikCald ErikCald changed the title RobotGamePieceState is no gamepiece but bottom, middle or top is pressed When RobotGamePieceState is NoGamePiece but bottom, middle or top button is pressed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NorthBay Tasks for north bay priority:medium Medium priority
Projects
None yet
Development

No branches or pull requests

3 participants