Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advantage kit implementation #58

Closed
wants to merge 27 commits into from
Closed

Advantage kit implementation #58

wants to merge 27 commits into from

Conversation

LuisFerArredondo
Copy link
Contributor

@LuisFerArredondo LuisFerArredondo commented Feb 10, 2024 •
edited
Loading

Describe your changes

  • Bug fix
  • New feature

Explain what you did:

Basically is the implementation of the logging system "Advantage-Kit", I'm sorry but i didnt know about this pull Request stuff so this branch currently doesnt not only has the advantage kit, it combines other tickets such as ticket #41 and #57

Issue ticket (add number) #14

https://github.com/FRC2706/2024-2706-Robot-Code/issues/...

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have tested thoroughly.
  • I have written documentation and explained about my changes to the best of my ability.

LuisFerArredondo and others added 22 commits February 2, 2024 16:38
@LuisFerArredondo
Beginning implementation
6c18bdd
@catlue
First commit
192cf7f
@LuisFerArredondo
Imported the drive, havent tested it yet
ed583ba
@catlue
Shooter update 2 - fed 3
224ed7d
@LuisFerArredondo
Something that i dont remember i changed
8eadb6c
@LuisFerArredondo
fixed some stuff
59af4c7
@LuisFerArredondo
Merge branch 'Shooter' of https://github.com/FRC2706/2024-2706-Robot-…
28b357d 
…Code into Shooter
@catlue
Update 3 - added tuner
e791cbd
@LuisFerArredondo
dont remember what i changed
54c95f5
@LuisFerArredondo
Merge branch 'Shooter' into Advantage-Kit-Implementation
3dbd613
@LuisFerArredondo
added shooter and intake for future integration
eed6399
@LuisFerArredondo
Something i missed
f6e420e
@ErikCald
Update photonlib to 2.1
d33d6de
@LuisFerArredondo
Pretty much done with the shooter
6d55927
@ErikCald
Merge pull request #53 from FRC2706/Erik-PhotonLibFile
899a071 
Update photonlib to 2.1
@LuisFerArredondo
Ready to import drive
d61254a
@LuisFerArredondo
Ready to impor drive pt2
c5c59c9
@LuisFerArredondo
nothing really
3bdffb7
@LuisFerArredondo
Implementing states
ab28c64
@LuisFerArredondo
Continue working on State Machine
d7fe184
@LuisFerArredondo
Merge branch 'main' into Advantage-Kit-Implementation
3d5e5ea
@LuisFerArredondo
Began with the arm implementation to advantage kit
5e3afcf
@LuisFerArredondo LuisFerArredondo self-assigned this Feb 10, 2024
@ErikCald
Copy link
Collaborator

ErikCald commented Mar 1, 2024

Closing as discussed, with the intention of re-opening it later.

@ErikCald ErikCald closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LuisFerArredondo LuisFerArredondo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuisFerArredondo @ErikCald @catlue