Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute monitors with an annotation #49

Open
mjhuber opened this issue Oct 9, 2019 · 4 comments
Open

Mute monitors with an annotation #49

mjhuber opened this issue Oct 9, 2019 · 4 comments
Labels
enhancement Adding additional functionality or improvements pinned Prevents stalebot from removing
Milestone

Comments

@mjhuber
Copy link
Collaborator

mjhuber commented Oct 9, 2019

Support for muting monitors by adding an annotation would be beneficial. For example, an annotation could be added to a kubernetes object:

kubernetes.io/astro/mute-until: "2019-12-30 00:00:00"

and a downtime would be created to turn off alerting for that object.

@stale
Copy link

stale bot commented Dec 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Marked as stale by stalebot label Dec 8, 2019
@lucasreed lucasreed added the pinned Prevents stalebot from removing label Dec 9, 2019
@stale stale bot removed the stale Marked as stale by stalebot label Dec 9, 2019
@lucasreed
Copy link
Contributor

One note: we shouldn't use kubernetes.io in the annotation name. astro.fairwinds.com is the prefix we use to override monitor fields. That should be appropriate here too.

@lucasreed lucasreed self-assigned this Dec 26, 2019
@lucasreed
Copy link
Contributor

I'll work on this.

@lucasreed lucasreed added the enhancement Adding additional functionality or improvements label Feb 5, 2020
@lucasreed lucasreed changed the title Mute monitors with an annotation [feature] Mute monitors with an annotation Feb 5, 2020
@lucasreed lucasreed changed the title [feature] Mute monitors with an annotation [feature] Feb 5, 2020
@lucasreed lucasreed changed the title [feature] Mute monitors with an annotation Feb 5, 2020
@lucasreed lucasreed removed their assignment Dec 11, 2020
@lucasreed
Copy link
Contributor

Adding to v2 milestone to be built in from the beginning (if deemed necessary)

@lucasreed lucasreed added this to the v2 milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements pinned Prevents stalebot from removing
Projects
None yet
Development

No branches or pull requests

2 participants