Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Scala module wrt Gradle module metadata fails due to Scala module build not adding GMM #6

Closed
cowtowncoder opened this issue Nov 21, 2020 · 4 comments

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Nov 21, 2020

As things are, Scala module does not yet contain Gradle 6 module metadata:

FasterXML/jackson-module-scala#478

mostly since it is built using sbt and adding support may not be feasible right now. Assuming this cannot be done in timeframe for Jackson 2.12, it probably makes sense to change GradleTest to exclude Scala module from tests.

I also realized that Scala 2.10 is no longer supported with Jackson 2.12, will remove that for now.

@cowtowncoder
Copy link
Member Author

@jjohannes WDYT?

@cowtowncoder
Copy link
Member Author

Looks like failure was only due to Scala module for Scala 2.10 (which was dropped in time for 2.12.0-rc2), commenting that out made the test pass, so this might not be problematic.
Leaving open for now, just in case.

@jjohannes
Copy link
Contributor

Thanks for analysing this @cowtowncoder.

The test was indeed failing only because Scala 2.10 support was dropped. So we not testing that anymore is the right call.

That the Scala libraries do not publish the module file is indeed not a problem in practice at the moment. That is, because if a Jackson module that has a dependency like this:

com.fasterxml.jackson:some-module:VERSION -> com.fasterxml.jackson.core:jackson-core:VERSION

Jackson Core will also bring in the BOM with version VERSION. And in total this will align to the right version.

This is probably true for many Jackson modules actually. Still I think it is good that we publish the module file with the BOM dependency for as many as we can, for consistency and also for addressing other use cases in the future.

I think you can close this issue. We can keep FasterXML/jackson-module-scala#478. I will answer there as well.

@cowtowncoder
Copy link
Member Author

Thank you @jjohannes -- that makes sense. And I agree, some level of redundancy is good for coverage and testing; users sometimes have incomplete dependencies and I assume overlapping definitions might help there.
Will close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants