-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for Scala module wrt Gradle module metadata fails due to Scala module build not adding GMM #6
Comments
@jjohannes WDYT? |
Looks like failure was only due to Scala module for Scala 2.10 (which was dropped in time for 2.12.0-rc2), commenting that out made the test pass, so this might not be problematic. |
Thanks for analysing this @cowtowncoder. The test was indeed failing only because Scala 2.10 support was dropped. So we not testing that anymore is the right call. That the Scala libraries do not publish the
Jackson Core will also bring in the BOM with version This is probably true for many Jackson modules actually. Still I think it is good that we publish the I think you can close this issue. We can keep FasterXML/jackson-module-scala#478. I will answer there as well. |
Thank you @jjohannes -- that makes sense. And I agree, some level of redundancy is good for coverage and testing; users sometimes have incomplete dependencies and I assume overlapping definitions might help there. |
As things are, Scala module does not yet contain Gradle 6 module metadata:
FasterXML/jackson-module-scala#478
mostly since it is built using
sbt
and adding support may not be feasible right now. Assuming this cannot be done in timeframe for Jackson 2.12, it probably makes sense to changeGradleTest
to exclude Scala module from tests.I also realized that Scala 2.10 is no longer supported with Jackson 2.12, will remove that for now.
The text was updated successfully, but these errors were encountered: