Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug(?)] Triple pressing acts as a double push instantly followed by a single press... #10

Open
IAmOrion opened this issue May 9, 2019 · 4 comments

Comments

@IAmOrion
Copy link

IAmOrion commented May 9, 2019

Triple pressing acts as a double push instantly followed by a single press. Realistically this should still fall under control of the debouncing methods, given that's it's highly unlikely someone wants to action a double press and then a single press like that. Ideally, it should not register the 3rd press... so in other words, it should action the double press method and ignore the 3rd press (within the debounce period)

@cconde
Copy link

cconde commented Jul 28, 2019

Might be a "multiple press" event and a register to read the number of presses.
That would fit all situations, the proposed one by IAmOrion and perhaps somebody coding an Easter egg after ten presses :)

@Fattoresaimon
Copy link
Owner

Hello,
In the version V2.1 i have fixed this issue.
After detecting a double push there is window of the same amount of the DPPERIOD where the button is not detected.

@IAmOrion
Copy link
Author

Hello,
In the version V2.1 i have fixed this issue.
After detecting a double push there is window of the same amount of the DPPERIOD where the button is not detected.

Do I have to upload a new firmware to the I2C encoder somehow? Or do I only need to update the library? I have the v2.0 board I believe

@Fattoresaimon
Copy link
Owner

You have to update the FW on the board. The FW is compatible.
You need a PIC programmer, like the PICKit 3.
In the datasheet it's written how to connect: https://github.com/Fattoresaimon/I2CEncoderV2.1/blob/master/EncoderI2CV2.1_v1.0.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants