Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion issue in BMI calculation #716

Open
aswathikrishnan24 opened this issue Jan 30, 2025 · 0 comments
Open

Conversion issue in BMI calculation #716

aswathikrishnan24 opened this issue Jan 30, 2025 · 0 comments

Comments

@aswathikrishnan24
Copy link

Describe the bug
Incorrect calculation due to conversion issue in WeightAssessmentandCounselingforNutritionandPhysicalActivityforChildrenandAdolescentsFHIR

Observations are picked incorrectly.
It considers all the measurements in measurement period and does not exclude the unexpected observations. For example, BMI percentile/ratio does not fall in measurement period, but it takes height and weight in the calculations which fall in the measurement period which are then included in BMI ratio calculations. The same happens for height and weight.

We believe the issue comes into play in line 282, where the Observations are filtered for BMI observations.
Image

This line refers to the isObservationBMI check, which does not seem to filter correctly:
Image

To Reproduce
Steps to reproduce the behavior:

  1. Go to WeightAssessmentandCounselingforNutritionandPhysicalActivityforChildrenandAdolescentsFHIR
  2. Click on 055edb62-3f1f-4b4e-8671-9ab319df0e94
  3. Run the test
  4. Numerator in first group is calculated as 1 when it is expected to be 0
Image

Version used:
Version: develop-2.0
46d3248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant