-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove train!
from quickstart example
#2110
Merged
+66
−40
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5631d6c
remove train from quickstart example
mcabbott adb1f8b
fixes & suggestions
mcabbott 221d435
better bullet points
mcabbott 0faaa25
dump train! and gpu from the readme too
mcabbott 27e1600
remove a few comments
mcabbott 0cb65e3
rm mention of Zygote
mcabbott 4ba8f74
maybe we should have a much simpler readme example
mcabbott 467c432
tweaks
mcabbott 881280b
no more cbrt, no more abs2
mcabbott ed64705
remove controversial println code, and make it shorter
mcabbott 739197d
fix some fences
mcabbott c0994c7
maybe this example should run on the GPU, since it easily can, even t…
mcabbott cd33b1a
let's replace explicit printing with showprogress macro, it's pretty …
mcabbott 9a2abbe
add graph of the loss, since we log it? also move to a folder.
mcabbott c9cde50
one more .. perhaps
mcabbott File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recent commit runs things on the GPU, as that seems worth showing off. (Even though this is actually slower). One quirk is that
model(noisy |> gpu) |> cpu
is a bit noisy, but maybe not so confusing to figure out.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this looks fine to me.