Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Optimisers to 0.4, (keep existing compat) #2520

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 8, 2024

This pull request changes the compat entry for the Optimisers package from 0.3.3 to 0.3.3, 0.4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.66%. Comparing base (c86580b) to head (b076f82).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2520      +/-   ##
==========================================
- Coverage   33.54%   31.66%   -1.88%     
==========================================
  Files          31       31              
  Lines        1911     1923      +12     
==========================================
- Hits          641      609      -32     
- Misses       1270     1314      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -55,7 +55,7 @@ MacroTools = "0.5"
NCCL = "0.1.1"
NNlib = "0.9.22"
OneHotArrays = "0.2.4"
Optimisers = "0.3.3"
Optimisers = "0.3.3, 0.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Optimisers = "0.3.3, 0.4"
Optimisers = "0.4"

@CarloLucibello CarloLucibello merged commit c51e6fb into master Nov 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants