Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Res2Net and Res2NeXt, again #195

Merged
merged 5 commits into from
Aug 11, 2022
Merged

Conversation

theabhirath
Copy link
Member

@theabhirath theabhirath commented Aug 3, 2022

This PR is an implementation for Res2Net and Res2NeXt, yet again. It closes #181 and closes #123 (supersedes) since those are now outdated, and makes use of the newest APIs merged in #174 and #190. More comprehensive docs for another PR in the revamp, perhaps, but this gets the models in with all possible configuration options

@theabhirath theabhirath added this to the 0.8 milestone Aug 3, 2022
@theabhirath theabhirath requested a review from darsnack August 3, 2022 17:17
@theabhirath theabhirath force-pushed the res2net-again branch 2 times, most recently from bc934aa to 61e55f9 Compare August 3, 2022 18:05
@theabhirath theabhirath changed the title Res2net and Res2NeXt, again Res2Net and Res2NeXt, again Aug 4, 2022
@theabhirath theabhirath added the new-model Request or implementation of a new model label Aug 4, 2022
Copy link
Member

@darsnack darsnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things. Looks ready!

src/convnets/resnets/core.jl Outdated Show resolved Hide resolved
src/convnets/resnets/res2net.jl Outdated Show resolved Hide resolved
src/convnets/resnets/core.jl Outdated Show resolved Hide resolved
src/convnets/resnets/res2net.jl Outdated Show resolved Hide resolved
src/convnets/resnets/resnet.jl Outdated Show resolved Hide resolved
@darsnack
Copy link
Member

Need to update the symbols in the resnet test suite.

@darsnack darsnack merged commit 842fa99 into FluxML:master Aug 11, 2022
@theabhirath theabhirath deleted the res2net-again branch August 11, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-model Request or implementation of a new model
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants