Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snooze not working in landscape #85

Closed
7 tasks done
Shadow-of-eagle opened this issue Aug 2, 2024 · 13 comments · Fixed by #122
Closed
7 tasks done

Snooze not working in landscape #85

Shadow-of-eagle opened this issue Aug 2, 2024 · 13 comments · Fixed by #122
Labels
bug Something is not working

Comments

@Shadow-of-eagle
Copy link

Shadow-of-eagle commented Aug 2, 2024

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.0.0

Affected Android/Custom ROM version

Android 8.1.0

Affected device model

Sony Xperia L3

How did you install the app?

Google Play Store

Steps to reproduce the bug

  1. Set an alarm
  2. Turn off the screen to get full screen Alarm
  3. When it goes off, rotate the device to landscape orientation, bevore you activate snooze
  4. Swipe to select snooze

Expected behavior

Snooze

Actual behavior

If in Landscape, the alarm just gets disabled (and does not start to gi off again after the set time intervall), no matter wich option is selected. If the device is rotated back to portrait orientation, bevore seting the alarm to snooze, it works as expected.

@Shadow-of-eagle Shadow-of-eagle added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Aug 2, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Aug 2, 2024
@TheRupp
Copy link

TheRupp commented Aug 17, 2024

I can replicate this bug.

Just to clarify: "the alarm just gets disabled" (in landscape) means, that the phone does not ring again after a few minutes (= "snoozing"). Instead nothing happens. This is the same as if the user swiped to the right to "Dismiss" an alarm.

app version 1.0.0
Android version 13 6.A.029.0
device = Fairphone 3+
How did you install the app? Google Play Store

@bobwms325
Copy link

This is happening to me as well. As soon as I start to swipe either left or right the alarm goes away and is not snoozed.

@Bigorthebest
Copy link
Contributor

Hello, I'm a young developer looking for my first issue to learn how to contribute to an open-source project.

I tested this bug with the latest version of the GitHub project on the Android Studio emulator (Medium Phone, API 35), and it seems that the bug is resolved. The alarm appears to work correctly after I snooze it and rotate the screen to landscape.

Did I test it correctly, or did I make a mistake?

@Aga-C
Copy link
Member

Aga-C commented Jan 30, 2025

The alarm appears to work correctly after I snooze it and rotate the screen to landscape.

Read once again the steps to reproduce.

@Bigorthebest
Copy link
Contributor

Capture.video.du.2025-01-30.11-18-01.webm

Maybe I'm just doing it wrong ?
Or it's because I'm using an emulator (Medium Phone, API 35) ?

@naveensingh
Copy link
Member

The original issue is about full screen alarms where as in your video I only see a notification. Try turning off the display using power button after setting your alarm.

@Aga-C
Copy link
Member

Aga-C commented Jan 30, 2025

Reproduction steps clearly say about "swiping", not about clicking on notification.

If you aren't familiar with the app to the point that you can properly understand reproduction steps, you shouldn't work on fixing the bug.

@Bigorthebest
Copy link
Contributor

Okay i got it now, i had to use the power button after setting my alarm to reproduce the bug.
Sorry for the confusion but English isn't my first language and i had trouble figuring out what "swiping" meant in that context.
Thanks for the help, I still want to try to work on it if its okay.

@Shadow-of-eagle
Copy link
Author

I edited the steps to reproduce, to make it more clear, what to do and avoid further missunderstandings.
Don't worry about the language, English is not my native language either.

@Bigorthebest
Copy link
Contributor

Hello again,

I created a pull request that attempts to fix the bug by preventing the activity from rotating when the alarm rings.

I understand that this may not be the expected solution, but I would like to hear your opinion.
I'm a computer science student trying to improve myself. Thank you for your patience.

@naveensingh
Copy link
Member

preventing the activity from rotating when the alarm rings.
I understand that this may not be the expected solution, but I would like to hear your opinion.

Yes, that's not the right way to solve this.

@Bigorthebest Bigorthebest mentioned this issue Mar 6, 2025
4 tasks
@Bigorthebest
Copy link
Contributor

Hello again,
I made a new and more conventional solution for the issue !
I'm ready to upgrade my pull request if you have any recommendation to help me improve.

@naveensingh
Copy link
Member

Thanks! I'll check it soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
6 participants