Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update folders on copy and move operations #11

Closed
wants to merge 2 commits into from
Closed

update folders on copy and move operations #11

wants to merge 2 commits into from

Conversation

gmasil
Copy link
Contributor

@gmasil gmasil commented Dec 14, 2023

This PR was originally created here: SimpleMobileTools/Simple-Gallery#3003

When you are sorting media files into folders by moving from one folder into several others (e.g. by category) currently the folders are only updated when you return to the main activity page.
That means if you sort your folders by date modified and start to move your files you will not update the order of your folders until you move back to the main page and return to the folder where you are sorting from.

This PR forces an update of source and target folder of copy/move operations so you will see the updated order of your folders immediately.

Steps to reproduce:

  1. Have at least three folders on your main page with at least two images inside each
  2. Have the option "File operations -> Keep old last-modified value at file operations" disabled
  3. Sort your folders and media inside folders by modification date descending
  4. Navigate inside a folder
  5. Move a file into the last folder

Expected behaviour:
If you now move/copy another file without returning to the main page you should see the last folder being moved up to the top (as it was just modified and it should be the first)

Actual behaviour:
The folder will stay the last folder until you return to the main page

@naveensingh
Copy link
Member

These PRs are being closed automatically by GitHub or some glitch. I'm not closing them.

@naveensingh naveensingh reopened this Jan 28, 2024
@naveensingh
Copy link
Member

@gmasil
I detached all the forked Fossify repositories and as a result, PRs originating from SMT forks are being closed automatically. Please consider the following solution:

  • Fork the new repository from Fossify.
  • Add your SMT fork as a remote and merge your changes.
  • Raise a new PR using the newly forked Fossify repository.

Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants