Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElasticRepository Retry on BulkResult error #1

Open
niemyjski opened this issue Jun 20, 2016 · 2 comments
Open

ElasticRepository Retry on BulkResult error #1

niemyjski opened this issue Jun 20, 2016 · 2 comments

Comments

@niemyjski
Copy link
Member

Some items may fail due to version change or multiple bulk results running at the same time. We should retry this and possibly return the number of modified documents (bulkResult.Items). Also, we should invalidate the cache before returning..

https://github.com/exceptionless/Foundatio.Repositories/blob/master/src/Elasticsearch/Repositories/ElasticRepositoryBase.cs#L178

@niemyjski
Copy link
Member Author

@ejsmith looks like what we talked about this morning :)

@niemyjski
Copy link
Member Author

Looks like we need to add

  1. the ability to pass a cancel token to a bulk operation
  2. return a result of what operations failed or succeed
  3. Handle retries when we encounter 429's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant