Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qc_signal_intensity plot merge (line 182) fails on pandas v1.3.0+ #52

Open
marcmaxson opened this issue Sep 2, 2021 · 1 comment
Open
Assignees

Comments

@marcmaxson
Copy link
Contributor

This code failed on circleci running pandas v1.3.2 (also tested and failed on 1.3.0) but works on earlier pandas versions (1.2.x).

               qc = pd.merge(left=medians,
               right=percent_failures_hues,
               left_on=medians.index,
               right_on=percent_failures_hues.index,
               how='inner')

something changed in pandas merge function.
https://pandas.pydata.org/docs/whatsnew/v1.3.0.html -- deprecated

possibly related to

Deprecated using merge(), DataFrame.merge(), and DataFrame.join() on a different number of levels (GH34862)
Deprecated merge() producing duplicated columns through the suffixes keyword and already existing columns (GH22818)

the error produced is:

ValueError: Unable to fill values because RangeIndex cannot contain NA

For now, the quick fix is to disallow pandas version 1.3.0 when installing methylcheck. But resolving the merge issue would be a better long term fix.

@marcmaxson marcmaxson self-assigned this Sep 2, 2021
@marcmaxson
Copy link
Contributor Author

Currently: methylcheck and methylprep specify using pandas v1.2x-v1.3x to avoid this bug. Hopefully a future version of pandas resolves this and we can open it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant