Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Remove useless commit from fshack that breaks Gallium Nine #783

Closed
niobium93 opened this issue Jun 9, 2022 · 3 comments
Closed

Comments

@niobium93
Copy link

So it turns out that this particular commit winex11.drv: Remove unused X11DRV_GET_DRAWABLE ExtEscape code. breaks Gallium Nine. This is part of both the _proton_fs_hack and _childwindow_fix patches in wine-tkg.

I have made a reverting patch and applied it as a userpatch in wine-tkg with fshack also enabled. This resulted in a build with both fshack and working Gallium Nine support.

This commit only removes dead code that wine with fshack applied no longer uses. However, Gallium Nine Standalone requires it.

There shouldn't be any issues simply removing it from the _proton_fs_hack and _childwindow_fix patch sets, so please consider doing so. Thanks! 😃

@rea987
Copy link

rea987 commented Sep 6, 2022

@niobium93 Hi! Are you happened to have an already build version of wine-tkg with that patch? It would be quite nice to have it. Thanks!

@niobium93
Copy link
Author

@rea987 wine-tkg has this by default now

@rea987
Copy link

rea987 commented Sep 6, 2022

@rea987 wine-tkg has this by default now

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants