Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure page permissions are respected in the recycle bin. #1

Open
rinti opened this issue Oct 20, 2020 · 0 comments
Open

Make sure page permissions are respected in the recycle bin. #1

rinti opened this issue Oct 20, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@rinti
Copy link
Member

rinti commented Oct 20, 2020

Right now the admin for the Recycle Bin shows RecycleBin-models with an attached Page. We should filter out RecycleBins that contains pages that the current user is not allowed to see.

To keep in mind: When adding a page to recycle bin it is effectively moved in the page structure, so if the page has permissions in an ancestor, that permission is now gone. This could be solved by first checking if the page has any pagepermissions attached, and if not get nearest ancestors page permissions.

The permission could then be added to the RecycleBin-model (not the RecycleBinPage-model)
@rinti rinti added the enhancement New feature or request label Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rinti