Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the travis.yml read the db name from the package.json? #164

Open
glebec opened this issue Mar 5, 2019 · 0 comments
Open

Make the travis.yml read the db name from the package.json? #164

glebec opened this issue Mar 5, 2019 · 0 comments

Comments

@glebec
Copy link
Member

glebec commented Mar 5, 2019

In theory we could add a script which outputs the db name, then use that from within travis.yml in the before_script field.

  • Pros
    • students wouldn't have to remember to update the project name in as many places
  • Cons
    • adding more cleverness to what is supposed to be a student code scaffold
    • removing an opportunity for them to interact with and understand travis.yml

I'm leaning towards not doing this, but figured it wouldn't hurt to make it an open discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant