Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AE2 [fluid]storage bus doesn't work with subnetted interface #17872

Open
3 tasks done
SKProCH opened this issue Nov 6, 2024 · 7 comments
Open
3 tasks done

AE2 [fluid]storage bus doesn't work with subnetted interface #17872

SKProCH opened this issue Nov 6, 2024 · 7 comments
Labels
Bug: Minor Mod: AE2FC Status: Needs More Info Issue requires more clarification from the author

Comments

@SKProCH
Copy link

SKProCH commented Nov 6, 2024

Your GTNH Discord Username

skproch

Your Pack Version

2.7.0-beta3

Your Server

private

Java Version

Java 21

Type of Server

Ultramine

Your Expectation

Fluid storage bus connected to dual interface should send fluids to subnet as item storage bus does.

The Reality

When i place fluid storage bus, set the filtered fluids near the dual interface (subnet), storage bus doesnt' send all this fluids to this subnet.

image

Your Proposal

Fluid interface should send fluids to subnet.

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@SKProCH SKProCH added Status: Triage Issue awaiting triage. Remove once this issue is processed Bug: Minor labels Nov 6, 2024
@Ruling-0 Ruling-0 added Status: Needs More Info Issue requires more clarification from the author Mod: AE2FC and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels Nov 8, 2024
@Ruling-0
Copy link

Ruling-0 commented Nov 8, 2024

Tested to work on a simple setup on Nightly 727 (filter storage to water, net has fluid terminal, dual interface net has storage, put water in terminal > water stored in dual interface net storage). Can you share more about your setup? Is there storage on the subnet the fluids could be going to instead? Is there storage available on the dual-interface side for the fluid to go to?

@lordIcocain
Copy link

idk if its related, but i noticed that fluid storage bus with pririty 1 and 0 sometimes swap recived fluid. It is in AL, bus with priority 1 got fluid for bus with 0, bus 0 got fluid for bus 1.

@SKProCH
Copy link
Author

SKProCH commented Nov 9, 2024

Tested to work on a simple setup on Nightly 727

Hmm, seems like this is also works in my SP test world. But doesn't work on server either with item storage buses.

Can you share more about your setup?

Just usual subnet which trying to store items in mainnet.

Is there storage on the subnet the fluids could be going to instead?

No, there is a sticky card on storage bus going to mainnet, so mainnet is the only options for fluids listed in storage bus.

Is there storage available on the dual-interface side for the fluid to go to?

Yeah, there is plenty of storage.

Btw, Items from AE2 output bus also don't pushed to mainnet (but if i place import bus in a subnet, it will send items to mainnet properly). So, i suspect there is some weirdness with my AE2 setup, but currently i've can't figure out exact conditions. If i can figure out this, i'll reopen this PR (or if someone else also experience that - let me know)

@SKProCH SKProCH closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2024
@SKProCH
Copy link
Author

SKProCH commented Nov 13, 2024

After a day of sitting with debugger, i figured out 2 main reasons for that:

  1. AE2 has user uuids cache file, and for my case there was ids 0 and 1, which are unknown uuids, we don't have this players in server username cache, this ids missing from namemc (and apparently minecraft). Server runs on online mode, and we have license accounts.
    For some reason my subnet storage busses has owner id 0 (guid from missing player), and security manager rejects attempts to interact with the mainnet.
    This is resolved by editing biometric cards with /nbtedit and putting these cards in security manager.

There were also cases when I lost access to my AE system when I entered the server. Server in online mode, i've using my license account, so apparently my uuid don't changed.

  1. Missing storagebusses handler.
    I've want briefly explain how this works. Every net has a GridCache object, which tracks all the inventories (cells, interfaces, storagebusses, crafting, etc). In my case it holds all subnet storagebusses, cells, etc, but storagebusses which linked to mainnet doesn't have handlers (objects represent an link to inventory kinda). So, apparently seems like when server starts subnet storage busses tries to create a handler, but mainnet interfaces doesn't yet ready, so it creates a null and marks it cached. After that this storage bus doesn't considered as storage variant.
    After i break and place mainnet interfaces this starts working.

This is explains however, why this issue can't be reproduced: to reproduce it we need a really big mainnet which takes a lot of time to fully initialize, or some bugged player ids in cache.

Probably 2 case can be fixed. I'll try to look at that, but reopening the issue if anyone want's to take a look. Also, i can share my backup if anyone needs it.

@SKProCH SKProCH reopened this Nov 13, 2024
@SKProCH SKProCH changed the title AE2FC fluid storage bus doesn't work with subnetted dual interface AE2FC storage bus doesn't work with mainnet interface Nov 13, 2024
@SKProCH SKProCH changed the title AE2FC storage bus doesn't work with mainnet interface AE2 [fluid]storage bus doesn't work with subnetted interface Nov 14, 2024
@SKProCH
Copy link
Author

SKProCH commented Nov 17, 2024

Seems like there is some nbt saving problem.

Block owner id was saved to "proxyname/p" in nbt data, e.g.:

image

This is a newly placed security manager.

But sometimes this data was lost, this is my mainnet security manager (which was placed by me, my id is 2):

image

And after that i've lost access to my mainnet (since owner changed from me to user with id 0). This happens a couple times, seems like after server restart.

If somebody also have this problem (what occasionally security manager refuses to work with owner), please describe your case here.

@emveevme
Copy link

emveevme commented Dec 10, 2024

I might be dumb about something, but it sounds like I have this issue? I'm on the release for 2.7.0 FWIW

I can't figure out how to view the NBT data for the biometric scanner, /nbtedit isn't a recognized command so it must be some external tool I'm unfamiliar with. I assume that reconfiguring the biometric scanner doesn't fix anything (also this is such a dumb mechanic to be buggy being in single player lol).

The issue I have definitely seems to affect accessing fluid storage on subnets being accessible from the main-net.

Hopefully this doesn't just muddy the water on this issue so I'm trying to be as descriptive as possible, I'm nowhere near as knowledgeable when it comes to this stuff. That being said, the one thing that strikes me as interesting is that setting the priority of the storage bus on the main-net to 1 seemed to remedy the issue like you had noticed as well. It seemed to fix some other problems I was having, too even though they shouldn't have been related.

So my EOH setup stores all of its stuff in a dedicated subnet. The item storage doesn't seem to matter whatsoever. The fluid storage is the issue, but it's inconsistent - I could see the stellar plasma, but I couldn't see oxygen plasma.

These are all before the priotity fix:

Here you can see the subnet's storage showing the 109G Oxygen Plasma:
image

And the setup with the storage bus connected to the main-net, facing the dual interface on the subnet (this is storage bus started working when I set the priority to 1)
image

image

You can see the storage bus does recognize the Oxygen plasma in the subnet:
image

If there's anything I can clarify or look in to specifically, just let me know.

@SKProCH
Copy link
Author

SKProCH commented Dec 12, 2024

/nbtedit command should be added by ServerUtilities (and probably should be available in SP in a last pack versions).

But i don't think this is somehow related to security manager, since you are trying to manipulate the subnet (without security manager) from mainnet. In my case this is being vice versa, and subnet fails the security check trying to manipulate the mainnet.
But you can check your world/AE2/settings.cfg and find the players section. For yo (since you play SP) it should contains only one value.

Did this is reproduceable after restart? Or you need to reconfigure storage bus every time? If you return priority back to 0, it stops working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Mod: AE2FC Status: Needs More Info Issue requires more clarification from the author
Projects
None yet
Development

No branches or pull requests

4 participants