Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar in ME terminal is broken #18285

Open
2 of 3 tasks
CatsLeftEar opened this issue Dec 8, 2024 · 20 comments
Open
2 of 3 tasks

Search bar in ME terminal is broken #18285

CatsLeftEar opened this issue Dec 8, 2024 · 20 comments
Labels
Bug: Minor Mod: AE2 Status: Needs Confirmation Issue requires more investigation/testing/confimation on how it is caused. Type: GUI

Comments

@CatsLeftEar
Copy link

Your GTNH Discord Username

Keyla3300

Your Pack Version

stable

Your Server

Epsilon

Java Version

Java 8

Type of Server

None

Your Expectation

Search bar work propely and show what i search for

The Reality

It shows related to the search items, but the search string is now very weirdly acting with what is being shown
image
Here i wrote "stone" three times, thats what items it shows me
image
"BF BF EB BF EB" shows, well, ebf.
I suppose it thinks of a spacebar as another string and not continuation of the initial search

Your Proposal

fix? idk if its intentional, but i doubt that

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@CatsLeftEar CatsLeftEar added Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed labels Dec 8, 2024
@RAFAEL-SOSA-UH RAFAEL-SOSA-UH added Mod: AE2 Type: GUI Status: Needs Confirmation Issue requires more investigation/testing/confimation on how it is caused. and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels Dec 9, 2024
@CatsLeftEar
Copy link
Author

Update: its not ae2, its NEI

@slprime
Copy link
Member

slprime commented Dec 10, 2024

NEI in latest version splits the search string into tokens by spaces. This makes it possible to write search query queries using multiple tokens such as -@#$&

To prevent this, you need to wrap the string in quotes.

https://discordapp.com/channels/181078474394566657/295669878222880769/1255915413020086348

@boubou19
Copy link
Member

quite annoying tbh, if i want to search for creeper head i should only see creeper heads not whatever matching creeper and head.

@slprime
Copy link
Member

slprime commented Dec 10, 2024

before it find items what have creeper head, now it find items what have creeper and head

@boubou19
Copy link
Member

boubou19 commented Dec 10, 2024

We should put this behind a config, or i can guarantee you that we will get many reports of this as a bug. Like an "advanced search mode" option in NEI config gui.

@Glease
Copy link
Contributor

Glease commented Dec 10, 2024

just for a bit of clarity, is it search terms connected with OR or AND?

@chochem
Copy link
Member

chochem commented Dec 10, 2024

a space is now a AND

@chochem
Copy link
Member

chochem commented Dec 10, 2024

quite annoying tbh, if i want to search for creeper head i should only see creeper heads not whatever matching creeper and head.

image
yea there is nothing else.

@slprime
Copy link
Member

slprime commented Dec 10, 2024

just for a bit of clarity, is it search terms connected with OR or AND?

before space use as space now as AND

@boubou19
Copy link
Member

boubou19 commented Dec 10, 2024

nothing wrong in this image:
image

but as soon as i add a w in the search:
image

Nothing changes because the wafer is correct and the boule despite not being correct, is still displayed, because in the tooltip it matches the w of the "raw ore"

That's not what i expect it to search.

@CatsLeftEar
Copy link
Author

NEI in latest version splits the search string into tokens by spaces. This makes it possible to write search query queries using multiple tokens such as -@#$&

To prevent this, you need to wrap the string in quotes.

https://discordapp.com/channels/181078474394566657/295669878222880769/1255915413020086348

Yeah, that needs a fix

@CatsLeftEar
Copy link
Author

image
plunger as an item pipe because in the flavor text is says "clears items from pipes" (which technically isnt even true"
image
heads, Large HP steam turbine, alchemical furnace, emerald chipset, Neutron sensor and, of course, Needs maintenance cover, when i search for Stone

@boubou19
Copy link
Member

We don't need a fix, we need a button to swap between AND and "space" treatment of the space in NEI

@slprime
Copy link
Member

slprime commented Dec 10, 2024

I will add a setting that should change this behavior.

@boubou19
Copy link
Member

typically something here:
image

@CatsLeftEar
Copy link
Author

CatsLeftEar commented Dec 10, 2024

I will add a setting that should change this behavior.

maybe a button that would remove search by flavor text in description, because most of the multiblock controllers have "redstone" in their description, as well as most of the covers, a lot of buildcraft items like chipsets etc. Even without spacebars, all that stuff is shown when you search for both "redstone" and "stone", as well as "red"
tbh, should it even consider flavor text (the only example of why it needs that is to search by "cover" to see gt blocks with covers on them (its shown in flavor text of a block)) or programming info as matching strings for when you search for an item in NEI/AE?

@slprime
Copy link
Member

slprime commented Dec 10, 2024

image
change this to Prefix

@boubou19
Copy link
Member

yeah but that's a ductape fix for the meantime, as i am used to do tooltip search. I'd be more than happy to just change the space treatment in the searchbar

@chochem
Copy link
Member

chochem commented Dec 10, 2024

a config is fine but please dont change it. space as AND has been a huge improvement compared to the old where you needed to use wildcard and still got screwed by incorrect order.

@slprime
Copy link
Member

slprime commented Dec 12, 2024

I don't know English, so I wanted you to help me with the name of the settings.

I added settings with 3 states:

  1. space works like - like it wotks before NEI search refactoring
  2. space works like AND - like now
  3. space works like AND, but tokens must be in one search type (name, tooltip, etc.)

For now I've called it this:

nei.options.inventory.search.spaceMode=Space Works as
nei.options.inventory.search.spaceMode.0=AND
nei.options.inventory.search.spaceMode.1=Space
nei.options.inventory.search.spaceMode.2=Extended

image

Example:

image

AND (search tokens in tooltip or title)
image

Space (search exact match. in example found in tooltip)
image

Extended (search for tokens in one type. In the example, 2 tokens were in the tooltip)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Mod: AE2 Status: Needs Confirmation Issue requires more investigation/testing/confimation on how it is caused. Type: GUI
Projects
None yet
Development

No branches or pull requests

6 participants