-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Bio and Breakthrough circuits from the modpack #3389
base: master
Are you sure you want to change the base?
Conversation
does it have conflict if you just remove the circuit alltogether ? |
even where it doesnt, it would just invite future problems. |
for machines like dehydrator or chem plant ? |
just mentioning in case you are not aware: custom-nei-diagram has a nice conflict checker |
May I suggest to change the Algae -> Cellulose Fiber recipes from Assembler to Dehydrator? It make more sense to me to dehydrate the biomass to get out the fibers compared to put them in an assembler which looks wiered at last to me. Sadly we have no LV Dehydrator so maybe make one as we have 41 recipes set to LV and with the Green Algae mentioned here it would be 42 ones doable in LV. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this removal, but this will need testing so no conflict arises.
this doesnt look finished, why is this approved? |
its draft need more work i guess |
This is not ready yet, I missed it was drafted.
@StaffiX guess you continue to work on this ? |
Yeah I'm going to, I was just waiting for the 2.7 release. |
Closes GTNewHorizons/GT-New-Horizons-Modpack#16539
Bio and Breakthrough circuits are programmed circuits added by GT++ that functions identically as programmed circuits.
This PR removes them from recipes, and convert already used bio and breakthrough circuit in people's bases via Postea.
Main function is to differentiate between recipes, but due to the minimal amount of usage, there is no point in them existing, and if there would be a need, could just increase the regular programmed circuit beyond 24.
I found no conflicts by just changing Bio X to regular programmed circuit X, since its mostly used in machines that have limited amount of recipes and usually uses bio ones, like chemical plant or dehydrator.
For assembler recipes i also didn't find any conflicts in full pack.
Missing: