Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bio and Breakthrough circuits from the modpack #3389

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

StaffiX
Copy link
Contributor

@StaffiX StaffiX commented Oct 19, 2024

Closes GTNewHorizons/GT-New-Horizons-Modpack#16539
Bio and Breakthrough circuits are programmed circuits added by GT++ that functions identically as programmed circuits.

This PR removes them from recipes, and convert already used bio and breakthrough circuit in people's bases via Postea.

Main function is to differentiate between recipes, but due to the minimal amount of usage, there is no point in them existing, and if there would be a need, could just increase the regular programmed circuit beyond 24.
I found no conflicts by just changing Bio X to regular programmed circuit X, since its mostly used in machines that have limited amount of recipes and usually uses bio ones, like chemical plant or dehydrator.
For assembler recipes i also didn't find any conflicts in full pack.

Missing:

  • Replacing breakthrough circuit recipes
  • Checking Coremod for breakthrough and bio recipes
  • Using Postea to convert them to regular circuits in players' machines
  • Double checking if there is truly no conflicts

@chochem chochem added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Oct 19, 2024
@Alexdoru
Copy link
Member

by just changing Bio X to regular programmed circuit X

does it have conflict if you just remove the circuit alltogether ?

@chochem
Copy link
Member

chochem commented Oct 19, 2024

by just changing Bio X to regular programmed circuit X

does it have conflict if you just remove the circuit alltogether ?

even where it doesnt, it would just invite future problems.

@Alexdoru
Copy link
Member

by just changing Bio X to regular programmed circuit X

does it have conflict if you just remove the circuit alltogether ?

even where it doesnt, it would just invite future problems.

for machines like dehydrator or chem plant ?

@chochem
Copy link
Member

chochem commented Oct 19, 2024

Double checking if there is truly no conflicts

just mentioning in case you are not aware: custom-nei-diagram has a nice conflict checker

@serenibyss serenibyss added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Oct 21, 2024
@Chaoschaot232
Copy link

Chaoschaot232 commented Oct 23, 2024

May I suggest to change the Algae -> Cellulose Fiber recipes from Assembler to Dehydrator?
Recipies are in general MV/HV only Green Algae Biomass has an LV Assembler ones to get Cellulose Fiber out.

It make more sense to me to dehydrate the biomass to get out the fibers compared to put them in an assembler which looks wiered at last to me.

Sadly we have no LV Dehydrator so maybe make one as we have 41 recipes set to LV and with the Green Algae mentioned here it would be 42 ones doable in LV.
Should only be checked if this would breake any progress when available for the other 41 LV recipes but from a first look at it I don't see any problems with this.

@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Dec 8, 2024
@Dream-Master Dream-Master requested a review from a team December 8, 2024 17:42
Ethryan
Ethryan previously approved these changes Dec 8, 2024
Copy link
Contributor

@Ethryan Ethryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this removal, but this will need testing so no conflict arises.

@chochem
Copy link
Member

chochem commented Dec 8, 2024

this doesnt look finished, why is this approved?

@Dream-Master
Copy link
Member

its draft need more work i guess

@Ethryan Ethryan dismissed their stale review December 8, 2024 18:48

This is not ready yet, I missed it was drafted.

@Dream-Master
Copy link
Member

@StaffiX guess you continue to work on this ?

@StaffiX
Copy link
Contributor Author

StaffiX commented Dec 9, 2024

Yeah I'm going to, I was just waiting for the 2.7 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove GT++ circuits (bio and breakthrough)
7 participants