Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

double patterns cribs #3461

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

double patterns cribs #3461

wants to merge 12 commits into from

Conversation

lordIcocain
Copy link
Contributor

@lordIcocain lordIcocain commented Nov 8, 2024 •
edited
Loading

@serenibyss serenibyss added the new feature Add something new. Please explain in detail how it works. label Nov 8, 2024
@Dream-Master Dream-Master requested a review from a team November 8, 2024 17:19
serenibyss
serenibyss reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is great, though the placement of the button is not ideal, I think this could be improved

@lordIcocain
Copy link
Contributor Author

@serenibyss I have no idea. Can you mark better placement?

image

@FireWarrior2
Copy link
Contributor

Add 9 extra pattern slots and there will be place))

@Dream-Master Dream-Master requested a review from a team November 11, 2024 23:15
@chochem chochem added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Nov 19, 2024
@Alexdoru
Copy link
Member

just place it outside like the buttons in the ae2 interfaces and so on
image

@lordIcocain
Copy link
Contributor Author

lordIcocain commented Nov 23, 2024 •
edited
Loading

just place it outside like the buttons in the ae2 interfaces and so on

Done.

@Dream-Master Dream-Master requested a review from a team November 27, 2024 13:19
@FireWarrior2
Copy link
Contributor

Will crafting input bus (no fluids) also have this button?

@lordIcocain
Copy link
Contributor Author

Will crafting input bus (no fluids) also have this button?

Yes

@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenibyss serenibyss serenibyss left review comments

@Alexdoru Alexdoru Alexdoru requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
new feature Add something new. Please explain in detail how it works.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Double Pattern" support to CRIBs
6 participants
@lordIcocain @FireWarrior2 @Alexdoru @serenibyss @Dream-Master @chochem