Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Maintenance texts to become easier to identify #3541

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nockyx
Copy link
Contributor

@Nockyx Nockyx commented Nov 23, 2024

Closes #17489

image

@Dream-Master
Copy link
Member

@Nockyx Good idea but the text overlapped (crowbar)

@Nockyx
Copy link
Contributor Author

Nockyx commented Nov 23, 2024

I know but I don't know how it could not overlap, any suggestion? I can't think of any that doesn't change the original text to be shorter.

to something like: " this shouldn't be there"

@HoleFish
Copy link
Contributor

@Nockyx
Copy link
Contributor Author

Nockyx commented Nov 23, 2024

190->189 will do

image
well, this happens 🤔

@Nockyx
Copy link
Contributor Author

Nockyx commented Nov 23, 2024

image
this works tho, but i don't know if it's ok to change the original text

@wlhlm
Copy link
Member

wlhlm commented Nov 23, 2024

this works tho, but i don't know if it's ok to change the original text

That's just a bandaid fix. If a translation requires longer text, the issue will surface again. There should be some line wrapping, and it seems there is according to the suggestion from @HoleFish. It's just that wrapped lines are indented too much. We should fix that.

@serenibyss serenibyss added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Nov 23, 2024
@chochem chochem added ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. new feature Add something new. Please explain in detail how it works. labels Nov 23, 2024
@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. new feature Add something new. Please explain in detail how it works.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance Issues
6 participants