Refactor Steam Input Bus to extend MTEHatchInputBus #3642
+65
−295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serenibyss
added
enhancement
serenibyss
reviewed
Dec 12, 2024
...ava/gtPlusPlus/xmod/gregtech/api/metatileentity/implementations/base/GTPPMultiBlockBase.java
Outdated
Show resolved
Hide resolved
...ava/gtPlusPlus/xmod/gregtech/api/metatileentity/implementations/base/GTPPMultiBlockBase.java
Outdated
Show resolved
Hide resolved
...ava/gtPlusPlus/xmod/gregtech/api/metatileentity/implementations/base/GTPPMultiBlockBase.java
Outdated
Show resolved
Hide resolved
.../java/gtPlusPlus/xmod/gregtech/api/metatileentity/implementations/MTEHatchSteamBusInput.java
Outdated
Show resolved
Hide resolved
...java/gtPlusPlus/xmod/gregtech/api/metatileentity/implementations/base/MTESteamMultiBase.java
Show resolved
Hide resolved
|
wouldnt that mean it will work with non-steam multiblocks? |
chochem
reviewed
Dec 12, 2024
| public String[] getDescription() { | ||
| return new String[] { "Item Input for Steam Multiblocks", | ||
| "Shift + right click with screwdriver to toggle automatic item shuffling", "Capacity: 4 stacks", | ||
| "Does not work with non-steam multiblocks", GTPPCore.GT_Tooltip.get() }; |
There was a problem hiding this comment.
sorry, should have put the comment here: wouldnt this change mean it will work with non-steam multiblocks?
chochem
added
the
Affects Balance
sorry, i will fix this when I can. didn't realize that would happen |
|
ok but then that has wider implications. would just make this a sneaky cheaper LV input bus. maybe there is some better way to do what you want? |
i meant limiting it to only steam multis, not changing to the tooltip to reflect how it works now |
purebluez
force-pushed
the
steaminputbus
branch
from
9b2203b to
45cf2f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GTNewHorizons/GT-New-Horizons-Modpack#18333
The Steam Input Bus currently extends MTEHatch instead of MTEHatchInputBus. Moving to MTEHatchInputBus gave it the following "new" features:
The file and its usages have also been renamed to 'MTEHatchSteamBusInput' from 'MteHatchSteamBusInput', since it conflicted with the existing standard for MTEs.
Here is a video showcasing the new features:
https://github.com/user-attachments/assets/bafe3f34-2db2-41d5-9f79-509f2d6a08d3