Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Causes Campfire Backport's animation to not work. #204

Open
MagmaBro123 opened this issue Mar 26, 2023 · 4 comments
Open

Causes Campfire Backport's animation to not work. #204

MagmaBro123 opened this issue Mar 26, 2023 · 4 comments

Comments

@MagmaBro123
Copy link

MagmaBro123 commented Mar 26, 2023 •
edited
Loading

Title. See video and modlist below.

image

javaw_ra44RY59c3.mp4
@Omgise
Copy link
Contributor

Omgise commented Apr 9, 2023

try disabling speedupAnimations in config and check if it fixes the issue

@MagmaBro123
Copy link
Author

Not sure why it took 3 weeks for a response, but yeah, disabling that fixes this. A proper fix would be nice though.

@connor135246
Copy link

connor135246 commented Oct 15, 2023 •
edited
Loading

Part of this is an issue in Hodgepodge. I believe the fire isn't being animated because of #264. This is probably a simple fix.

Part of this is kind of my fault. I believe the embers on the logs aren't animated because... I don't actually use the renderFace methods in RenderBlocks that the injection here points to. Even if I did go back to using the traditional renderFace methods to fix this, I also have a custom crossed squares method that uses two icons which would still be broken (I use this in NEI to represent recipes that work for both types of campfires). So I don't see a simple fix. API for speedupAnimations? Nah, probably just an annoyance you'll have to accept.

makamys added a commit to GTNewHorizons/Angelica that referenced this issue Jan 21, 2024
@makamys
Add Campfire Backport compatibility to animation speedup
aeb0f81 
Fixes Angelica's equivalent of GTNewHorizons/Hodgepodge#204
Fixes embers and NEI mixed flames not animating
@mitchej123
Copy link
Contributor

We'll likely add an API for speedupAnimations as mentioned, but for now we'll work around it in Angelica (which is where this was moved to)

mitchej123 pushed a commit to GTNewHorizons/Angelica that referenced this issue Jan 21, 2024
@makamys
Fix campfire backport animations (#224)
3755e25 
* Mark animations of crossed squares

Fixes Angelica's equivalent of GTNewHorizons/Hodgepodge#264
Fixes Campfire Backport campfire flames not animating (but the embers and the
mixed NEI flames are still broken)

* Add Campfire Backport compatibility to animation speedup

Fixes Angelica's equivalent of GTNewHorizons/Hodgepodge#204
Fixes embers and NEI mixed flames not animating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mitchej123 @MagmaBro123 @connor135246 @Omgise