-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compact chat #243
Compact chat #243
Conversation
Any reason? It's the same behavior as newer versions of mc |
I thought that it was added to prevent chat spamming, since with compact chat there is no spam anymore I tough I would disable it |
It's just my personal opinion, since this pr adds compact chat, I'd prefer to see the bed message in the chat and not above the hotbar, ngl when testing at first I didn't even see the bed message above the hotbar until I went into the git log to find what happened lol. Feel free to put the setting back the true by default if you want |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @miozune that the current behaviour should be kept.
src/main/java/com/mitchej123/hodgepodge/client/chat/ChatHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mitchej123/hodgepodge/mixins/early/minecraft/MixinGuiNewChat_CompactChat.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mitchej123/hodgepodge/mixins/early/minecraft/MixinGuiNewChat_CompactChat.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mitchej123/hodgepodge/mixins/early/minecraft/MixinGuiNewChat_CompactChat.java
Outdated
Show resolved
Hide resolved
I did not add the types at first because I did not know how it would behave with the source code that doesn't have them |
@Alexdoru can you resolve the conflict ? |
# Conflicts: # src/main/java/com/mitchej123/hodgepodge/LoadingConfig.java
Compacts identical consecutive chat messages together
Also disabled by default the message "You can only sleep at night" rendering above the hotbar