Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact chat #243

Merged
merged 5 commits into from
Sep 17, 2023
Merged

Compact chat #243

merged 5 commits into from
Sep 17, 2023

Conversation

Alexdoru
Copy link
Member

@Alexdoru Alexdoru commented Sep 16, 2023

Compacts identical consecutive chat messages together

image

Also disabled by default the message "You can only sleep at night" rendering above the hotbar

@miozune
Copy link
Member

miozune commented Sep 16, 2023

Also disabled by default the message "You can only sleep at night" rendering above the hotbar

Any reason? It's the same behavior as newer versions of mc

@Alexdoru
Copy link
Member Author

Any reason? It's the same behavior as newer versions of mc

I thought that it was added to prevent chat spamming, since with compact chat there is no spam anymore I tough I would disable it

@miozune
Copy link
Member

miozune commented Sep 16, 2023

Bed message spam was fixed predate hotbar HUD, #102. I introduced #205 because it looks more fancy

@Alexdoru
Copy link
Member Author

Bed message spam was fixed predate hotbar HUD, #102. I introduced #205 because it looks more fancy

It's just my personal opinion, since this pr adds compact chat, I'd prefer to see the bed message in the chat and not above the hotbar, ngl when testing at first I didn't even see the bed message above the hotbar until I went into the git log to find what happened lol.

Feel free to put the setting back the true by default if you want

Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @miozune that the current behaviour should be kept.

@Alexdoru
Copy link
Member Author

I did not add the types at first because I did not know how it would behave with the source code that doesn't have them

@Alexdoru Alexdoru requested a review from glowredman September 16, 2023 19:08
@Dream-Master
Copy link
Member

@Alexdoru can you resolve the conflict ?

# Conflicts:
#	src/main/java/com/mitchej123/hodgepodge/LoadingConfig.java
@Dream-Master Dream-Master requested review from a team September 16, 2023 19:46
@Alexdoru Alexdoru merged commit a190804 into master Sep 17, 2023
1 check passed
@Alexdoru Alexdoru deleted the compact-chat branch September 17, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants