Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move resolveAbsoluteAddress to a different module #11

Open
RyanGlScott opened this issue Mar 21, 2022 · 1 comment
Open

Move resolveAbsoluteAddress to a different module #11

RyanGlScott opened this issue Mar 21, 2022 · 1 comment

Comments

@RyanGlScott
Copy link
Contributor

RyanGlScott commented Mar 21, 2022 •
edited
Loading

The resolveAbsoluteAddress function currently lives in Data.Macaw.BinaryLoader.ELF, but despite its name, there is nothing ELF-specific about it whatsoever. In light of this, we should move resolveAbsoluteAddress to a less misleading location.
@RyanGlScott
Copy link
Contributor Author

It might also benefit to rename resolveAbsoluteAddress to something else. Its name is quite similar to macaw:Data.Macaw.Memory.resolveAbsoluteAddr, but the two functions serve very different purposes.

@RyanGlScott RyanGlScott mentioned this issue May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RyanGlScott