Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript checks #17

Open
2 tasks
capital-G opened this issue May 10, 2023 · 1 comment
Open
2 tasks

Add typescript checks #17

capital-G opened this issue May 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@capital-G
Copy link
Member

Currently we do not run typechecks, so we are not using the features of typescript.

Nuxt offers a guide https://nuxt.com/docs/guide/concepts/typescript but I could not get this to work (I enforced a type violation and it did not complain, so the type check is useless as described there?)

DoD

  • Type checks fail if we introduce violations
  • Type checks run in CI
@capital-G capital-G added the enhancement New feature or request label May 10, 2023
@capital-G
Copy link
Member Author

I really don't understand nuxt in this regard - following the official guide https://nuxt.com/docs/guide/concepts/typescript does not help as creating a type-bug within the code does not get explored, rendering the type-checking useless

there are multiple issues, some stating that the implicit auto-import creates issues, but even when turning this off and running the type-check does not yield any errors, while running the nuxt server yields in a runtime error :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant