Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12862] Allow to add metadata when uploading a resource #12874

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ridoo
Copy link
Contributor

@ridoo ridoo commented Feb 4, 2025

[Currently work in progress]

Reads and passes custom json payload during upload to be set on the new geonode resource. Should work also for resources which shall be overridden.

This PR contains some fixes/changes of seemingly unrelated parts where errors occured during testing. The proposed changes have to be reviewed and discussed first. Chances are that I missed important parts. However, this PR reveals those locations better than my comment on the related issue.

Referenced ticket: #12862

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Feb 4, 2025
@ridoo ridoo force-pushed the feature/12862_allow-to-add-metadata-when-uploading-a-resource branch 7 times, most recently from cfcd549 to b28b8cb Compare February 4, 2025 17:37
@ridoo ridoo force-pushed the feature/12862_allow-to-add-metadata-when-uploading-a-resource branch from b28b8cb to d1957c9 Compare February 5, 2025 07:17
@ridoo ridoo linked an issue Feb 5, 2025 that may be closed by this pull request
@ridoo ridoo requested a review from mattiagiupponi February 5, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to add metadata when uploading a resource
1 participant