Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Play PeerTube videos in Tuba #662

Open
1 task done
LukaszH77 opened this issue Nov 25, 2023 · 3 comments
Open
1 task done

[Request]: Play PeerTube videos in Tuba #662

LukaszH77 opened this issue Nov 25, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@LukaszH77
Copy link
Contributor

Describe the request

Is it possible for PeerTube videos to be played in Tuba's media viewer?

PeerTube is becoming more and more popular and it would be nice if I didn't have to open another app to watch videos from PT accounts I follow from Mastodon.

Implementation Details

@LukaszH77 LukaszH77 added the enhancement New feature or request label Nov 25, 2023
@GeopJr
Copy link
Owner

GeopJr commented Nov 25, 2023

It exists in Tuba right now but it's disabled, more info:
#244
#245
#253

The main issues are:

  1. PeerTube supports at least 2 ways of showing videos, either streaming it or providing the whole file. The implementation currently in Tuba supports only streaming, but feat(PreviewCard): support PeerTube mp4 #253 adds file support too (though that PR hasnt been updated in a while). The way streaming works in Tuba has the following issue too, of not knowing how long the video is

image
(ignore the zoom buttons, I haven't enabled PeerTube support in a while and hadn't noticed it during the media viewer refactors)

  1. The video sometimes just stops updating while the sound keeps playing, the cause of which might be the way I handle files in that PR. A potential fix would be to use the inputstreams directly but that's not possible at the moment due to gstreamer(?) bug (upstream is aware)

If you want to give it a try, change this to true and click the preview card of a peertube post (the peertube instance has to use streaming however, can't remember if they can disable it. I usually use https://tube.kockatoo.org/videos/local for testing)

I'll leave this issue open to track any progress!

@LukaszH77
Copy link
Contributor Author

Thank you for your answer, I'll check it out later

@reinouts
Copy link

Perhaps it would be possible to delegate YouTube and PeerTube videos to Pipeline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants