Skip to content
This repository was archived by the owner on Nov 24, 2020. It is now read-only.

upgrade to 2.6 #19

Closed
nagim opened this issue May 11, 2016 · 5 comments
Closed

upgrade to 2.6 #19

nagim opened this issue May 11, 2016 · 5 comments
Labels

Comments

@nagim
Copy link

nagim commented May 11, 2016

Hi,

There is a bug in the <2.6 mathjax versions, where there's a trailing | rendered in Chrome at the end of the formulas.
An upgrade to 2.6 would eliminate the issue (and the need to hide it with CSS rules).

Thanks,
Imre

@SamyPesse
Copy link
Member

The last version of the plugin uses MathJax 2.6, you can even configure it: https://github.com/GitbookIO/plugin-mathjax/blob/master/package.json#L34

@nagim
Copy link
Author

nagim commented May 11, 2016

Thanks, I will try to force the version, because if I check the formula in the browser, it reports mathjax 2.5.3.

@nagim
Copy link
Author

nagim commented May 17, 2016

Tried to force the version, but from the build log, it seems that v2.5.1 is used despite of that:

info: install plugin mathjax from npm (gitbook-plugin-mathjax) with version 1.0.2 
make: Entering directory `/tmp/book/node_modules/gitbook-plugin-mathjax/node_modules/MathJax-node/node_modules/jsdom/node_modules/contextify/build'
  CXX(target) Release/obj.target/contextify/src/contextify.o
  SOLINK_MODULE(target) Release/obj.target/contextify.node
  SOLINK_MODULE(target) Release/obj.target/contextify.node: Finished
  COPY Release/contextify.node
make: Leaving directory `/tmp/book/node_modules/gitbook-plugin-mathjax/node_modules/MathJax-node/node_modules/jsdom/node_modules/contextify/build'
[email protected] node_modules/gitbook-plugin-mathjax
├── [email protected]
├── [email protected]
└── [email protected] ([email protected], [email protected], [email protected], [email protected])

Was using GitBook 2.6.7.

@pkra
Copy link

pkra commented May 17, 2016

Just a side note: MathJax-node was renamed mathjax-node a while back (and thus is stuck at 0.3 whereas mathjax-node is at 0.5.1).

@nagim
Copy link
Author

nagim commented Jun 3, 2016

@SamyPesse, could you please merge the #20 PR regarding the package name/version, so we can use the latest?

Thanks a lot!

Cheers,
Imre

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants