Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Giveth QF UX to simplify estimated matching #4977

Open
laurenluz opened this issue Jan 27, 2025 · 7 comments
Open

Update to Giveth QF UX to simplify estimated matching #4977

laurenluz opened this issue Jan 27, 2025 · 7 comments
Assignees
Labels
QF Quadratic Funding Related

Comments

@laurenluz
Copy link
Member

We have put extensive hours into improving the estimated matching to accomodate Cluster Matching, but have found it too problematic.

To solve the problem of project owners' complaints around inaccurate estimated matching, we should remove the calculations from project view, and keep estimations only on the individual donations. This requires design changes, outlined below.

  1. Project card (NEEDS DESIGN)
  • remove estimated matching number
  • keep "amount raised in the round"
  • keep "total raised"
  • keep qf round badge
  • add "unique donors in the round" or "raised from x contributors in this round"

Image

  1. Project details page (NEEDS DESIGN)
  • remove the big estimated matching number (for the project), but keep the estimations box, amount raised & contributors

Image

  1. Project details page donations tab
  • We have different conditions for this thing, aka:
    a. During the active QF round (past the "start time" and before the "end time") (NEEDS DESIGN)
  • Here we should remove the estimated matching number, and just show the number of contributors and the amount raised so far.

Image

b. Following the QF round, but before funds are distributed (NO CHANGE)

  • Here we should show a placeholder for the estimated matching number, a "pending" value, similar to what we have currently in the design.

Image

c. Folliowing the QF round, after funds are distributed and in the backend (NO CHANGE)

  • Here we should keep what we have currently... show the actual number for matching and the tx link.

Image

  1. Donate page (NO CHANGE)

Image

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Jan 27, 2025
@laurenluz laurenluz added the QF Quadratic Funding Related label Jan 27, 2025
@laurenluz laurenluz moved this from New Issues to Design in All-Devs Jan 27, 2025
@laurenluz laurenluz assigned mosaeedi and unassigned mhmdksh Jan 27, 2025
@mosaeedi
Copy link
Collaborator

Here are the designs
Figma link

@laurenluz
Copy link
Member Author

@mosaeedi a couple of small comments in here before this is ready to move to dev. can you have a look?

@laurenluz
Copy link
Member Author

Acceptance Criteria

  • On the /projects page /qf page and anywhere else the project card appears (e.g. "similar projects", "newly verified" etc.) for a project in a QF round (that is past the start time and before the end time), the card should look like this
    Image
    Image

  • For projects not in an active and live QF round, the project card looks like this:
    Image
    Image

Project cards link to figma

On the project details page:

  • Top box link to figma for projects in an active QF round (during the QF round period):
    Image

  • On the "donations" tab, QF round subtab, link to figma for projects in an active QF round (during the QF round period):
    Image

No change on other conditions including:

  • The "donations" tab, QF round subtab, for projects that were in an active QF round, that is now over, but funds have not yet been sent (i.e. tx has not yet been added to the backend)
  • The "donations tab", QF round subtab, for projects that were in an active QF round that is now over, after funds have been distributed for the round and tx added to the backend.
  • Donate page during a QF round
  • Project details page for projects in QF rounds

@laurenluz laurenluz moved this from Design Backlog to Design Done in All-Devs Feb 21, 2025
@laurenluz laurenluz moved this from Design Done to Design In Progress in All-Devs Feb 21, 2025
@laurenluz laurenluz removed the Design label Feb 22, 2025
@laurenluz laurenluz moved this from Design In Progress to Product Backlog in All-Devs Feb 22, 2025
@divine-comedian divine-comedian moved this from Product Backlog to Sprint Backlog in All-Devs Feb 24, 2025
@kkatusic kkatusic self-assigned this Feb 25, 2025
@kkatusic kkatusic moved this from Sprint Backlog to In Progress in All-Devs Feb 25, 2025
@kkatusic kkatusic moved this from In Progress to Code Review/PR in All-Devs Feb 27, 2025
@kkatusic kkatusic moved this from Code Review/PR to QA in All-Devs Feb 28, 2025
@divine-comedian
Copy link
Contributor

@LatifatAbdullahi - are you able to QA this issue?

Lauren has provided the AC here -> #4977 (comment)

@LatifatAbdullahi
Copy link

Test update

PROJECT CARD

  • Remove estimated matching number - Pass
  • Keep "amount raised in the round" - Pass
  • Keep "total raised" - Pass
  • Keep Qf round badge - Pass
  • Add "unique donors in the round" or "raised from x contributors in this round" - Pass

PROJECT DETAILS PAGE

  • Remove the big estimated matching number (for the project), but keep the estimations box, amount raised & contributors - Pass

PROJECT DEATAILS PAGE DONATIONS TAB

a. During the active QF round (past the "start time" and before the "end time")

  • Here we should remove the estimated matching number, and just show the number of contributors and the amount raised so far - Pass
    b. Following the QF round, but before funds are distributed (NO CHANGE)

  • Here we should show a placeholder for the estimated matching number, a "pending" value, similar to what we have currently in the design - Pass
    c. Following the QF round, after funds are distributed and in the backend (NO CHANGE)

  • Here we should keep what we have currently... show the actual number for matching and the tx link - Pass
    d. Donate page (NO CHANGE) - Pass

  • On the /projects page /qf page and anywhere else the project card appears (e.g. "similar projects", "newly verified" etc.) for a project in a QF round (that is past the start time and before the end time), the card should look like as displayed in the AC - Pass

  • For projects not in an active and live QF round, the project card looks like as displayed in the AC - Pass

@LatifatAbdullahi LatifatAbdullahi moved this from QA to Done in All-Devs Mar 3, 2025
@LatifatAbdullahi
Copy link

@kkatusic

The status "Vouched"/"Verified" and "Givback" are all displayed in CAPs on the App but not in the designs.

Image

@LatifatAbdullahi LatifatAbdullahi moved this from Done to QA in All-Devs Mar 3, 2025
@kkatusic kkatusic moved this from QA to In Progress in All-Devs Mar 3, 2025
@kkatusic kkatusic moved this from In Progress to Code Review/PR in All-Devs Mar 3, 2025
@kkatusic kkatusic moved this from Code Review/PR to QA in All-Devs Mar 3, 2025
@LatifatAbdullahi
Copy link

Thanks @kkatusic it is fixed now

@LatifatAbdullahi LatifatAbdullahi moved this from QA to Done in All-Devs Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QF Quadratic Funding Related
Projects
Status: Done
Development

No branches or pull requests

6 participants