Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivated and Cancelled projects - can still navigate to donate page #5008

Open
divine-comedian opened this issue Feb 6, 2025 · 5 comments
Assignees

Comments

@divine-comedian
Copy link
Contributor

divine-comedian commented Feb 6, 2025

testing on production
ubuntu 24.04
brave browser

when viewing a project with a status of deactivated or cancelled it is still possible to click and navigate through the donation page for the given project. I can see the button text is greyed out however it is still clickable and navigation works.

it's even possible to start a recurring donation for these projects since the donate button there is not disabled or greyed out at all

expected behaviour

it should be impossible to click the "Donate" button for a deactivated project on the project details page
it should be impossibleto click the "Donate" button for a deactivated project on the recurring donations page

Screencast.from.2025-02-06.07-22-47.mp4

example of deactivated project:
https://staging.giveth.io/project/mejana

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Feb 6, 2025
@divine-comedian divine-comedian moved this from New Issues to Product Backlog in All-Devs Feb 6, 2025
@maryjaf
Copy link
Collaborator

maryjaf commented Feb 25, 2025

Can I work on this issue? @divine-comedian

@maryjaf
Copy link
Collaborator

maryjaf commented Feb 25, 2025

Detailed Test Steps for UI Testing:

  1. Open the Brave browser on an Ubuntu 24.04 system.
  2. Navigate to the provided URL: https://staging.giveth.io/project/mejana.
  3. Verify that the project page for the "Mejana" project loads successfully.
  4. Check the status of the project to ensure it is set as deactivated or cancelled.
  5. Locate and click on the "Donate" button on the project details page.
  6. Verify if the button behavior aligns with the expected behavior as described in the issue description.
  7. Navigate to the recurring donations page.
  8. Attempt to initiate a recurring donation for the deactivated or cancelled project.
  9. Verify if the "Donate" button behavior on the recurring donations page conforms to the expected behavior.

Positive Test Scenarios:

  1. Verify that when viewing an active project, the "Donate" button is clickable, and navigation to the donation page works as expected.
  2. Ensure that for a project with the status "live," donation functionality functions correctly, allowing users to initiate donations without any issues.

Negative Test Scenarios:

  1. Attempt to click the "Donate" button on a deactivated project's details page and confirm that it does not allow navigating to the donation page.
  2. Test initiating a recurring donation for a project with a cancelled status and ensure that the "Donate" button is disabled or not clickable as expected.

@divine-comedian
Copy link
Contributor Author

@maryjaf take it!

@divine-comedian divine-comedian moved this from Product Backlog to Sprint Backlog in All-Devs Feb 25, 2025
@maryjaf maryjaf self-assigned this Feb 25, 2025
@maryjaf
Copy link
Collaborator

maryjaf commented Feb 26, 2025

In one time donation this message is shown like as below pic "This project is not active."
should it be shown in recurring donation like as one time donation or only the Donate button should be changed to disabled button? @divine-comedian

Image Image

@maryjaf maryjaf moved this from Sprint Backlog to In Progress in All-Devs Feb 26, 2025
@divine-comedian
Copy link
Contributor Author

@maryjaf nice catch! can you similarly implement the same toast warning above the donate button on recurring donation view?

@maryjaf maryjaf moved this from In Progress to Code Review/PR in All-Devs Mar 3, 2025
@maryjaf maryjaf moved this from Code Review/PR to QA in All-Devs Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

No branches or pull requests

3 participants