-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add eligible donations to qfround entity #1124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CarlosQ96 it's a great simple solution, just wondering if default value for eligileDonations should be empty array or an array of all supported networks, I'm worried about previous rounds
I thought about the empty state to reduce the workload for admins, and also instead of deleting each, just add those they want. |
You are right, so if you just modify the migration file to fill previous qfRounds eligibleNetworks to make sure we would not have any problem on them would be great |
Ok ill add the migration tomorrow morning. |
@mohammadranjbarz ready for final review and merging. Also for frontend they should check the attribute |
Related to the meeting we had. but I cant find the issue. Or if @laurenluz created it.
Can add array of networks to qfround and in the donation creation decides if marking or not