Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add eligible donations to qfround entity #1124

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

CarlosQ96
Copy link
Collaborator

@CarlosQ96 CarlosQ96 commented Sep 10, 2023

Related to the meeting we had. but I cant find the issue. Or if @laurenluz created it.

Can add array of networks to qfround and in the donation creation decides if marking or not

@CarlosQ96 CarlosQ96 marked this pull request as ready for review September 11, 2023 06:47
Copy link
Collaborator

@mohammadranjbarz mohammadranjbarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CarlosQ96 it's a great simple solution, just wondering if default value for eligileDonations should be empty array or an array of all supported networks, I'm worried about previous rounds

@CarlosQ96
Copy link
Collaborator Author

I thought about the empty state to reduce the workload for admins, and also instead of deleting each, just add those they want.

@mohammadranjbarz
Copy link
Collaborator

I thought about the empty state to reduce the workload for admins, and also instead of deleting each, just add those they want.

You are right, so if you just modify the migration file to fill previous qfRounds eligibleNetworks to make sure we would not have any problem on them would be great

@CarlosQ96
Copy link
Collaborator Author

Ok ill add the migration tomorrow morning.

@CarlosQ96
Copy link
Collaborator Author

@mohammadranjbarz ready for final review and merging.

Also for frontend they should check the attribute
eligibleNetworks in the graphql results in any query they fetch this info.

@CarlosQ96 CarlosQ96 merged commit c4f8012 into staging Sep 14, 2023
3 checks passed
@CarlosQ96 CarlosQ96 deleted the feature_add_network_elegibility_to_qf branch September 14, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants