Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC]: Configuration of the z offset applied during coregistration : possibility to deactivate the vertical shift #643

Open
quinto-clara opened this issue Nov 12, 2024 · 0 comments

Comments

@quinto-clara
Copy link

quinto-clara commented Nov 12, 2024

Context

The purpose of this ticket is to propose a solution that allows the user to control altitude adjustment after coregistration.

Code

⚠️ To do this, I need to locate in the code the condition that enables or disables Z-adjustment, which I can no longer find.

In practice, this condition rarely, if ever, fails, meaning that the Z-offset is almost always applied. However, in the context of QA studies, this adjustment is not always relevant. The simplest proposal is to add an argument to the function containing this condition, which can be toggled using a boolean. Depending on its state, the Z-adjustment will either be applied or skipped. This boolean can default to True.

Testing

Ensure to update any tests that may be affected and test with both boolean states.

Documentation

Update the documentation accordingly.

Extra

If possible, create a notebook demonstrating the use of this adjustment, including a before-and-after altitude comparison.

Estimation

2 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant