Fixed Update All so it correctly updates implicit dependencies (#699)

* Fixed Update All so it correctly updates implicit dependencies
---------
Co-authored-by: JoC0de <[email protected]>

Author: igor84

src/NuGetForUnity/Editor/Ui/NugetWindow.cs

@@ -190,23 +190,7 @@ private List<INugetPackage> FilteredUpdatePackages
                 var installedPackages = InstalledPackagesManager.InstalledPackages;
 
                 // filter not updatable / not downgradable packages
-                return result.Where(
-                        package =>
-                        {
-                            var installed = installedPackages.FirstOrDefault(p => p.Id.Equals(package.Id, StringComparison.OrdinalIgnoreCase));
-
-                            if (installed == null || package.Versions.Count == 0)
-                            {
-                                // normally shouldn't happen but for now include it in the result
-                                return true;
-                            }
-
-                            // we do not want to show packages that have no updates if we're showing updates
-                            // similarly, we do not show packages that are on the lowest possible version if we're showing downgrades
-                            return (showDowngrades && installed.PackageVersion > package.Versions[package.Versions.Count - 1]) ||
-                                   (!showDowngrades && installed.PackageVersion < package.Versions[0]);
-                        })
-                    .ToList();
+                return FilterUpdatableOrDowngradablePackages(result).ToList();
             }
         }
 
@@ -405,6 +389,31 @@ private void OnEnable()
             UnityPathHelper.EnsurePackageInstallDirectoryIsSetup();
         }
 
+        /// <summary>
+        ///     Filter not updatable / not downgradable packages based on showDowngrades.
+        /// </summary>
+        private IEnumerable<INugetPackage> FilterUpdatableOrDowngradablePackages(IEnumerable<INugetPackage> packages)
+        {
+            var installedPackages = InstalledPackagesManager.InstalledPackages;
+
+            return packages.Where(
+                package =>
+                {
+                    var installed = installedPackages.FirstOrDefault(p => p.Id.Equals(package.Id, StringComparison.OrdinalIgnoreCase));
+
+                    if (installed == null || package.Versions.Count == 0)
+                    {
+                        // normally shouldn't happen but for now include it in the result
+                        return true;
+                    }
+
+                    // we do not want to show packages that have no updates if we're showing updates
+                    // similarly, we do not show packages that are on the lowest possible version if we're showing downgrades
+                    return (showDowngrades && installed.PackageVersion > package.Versions[package.Versions.Count - 1]) ||
+                           (!showDowngrades && installed.PackageVersion < package.Versions[0]);
+                });
+        }
+
         private void ClearViewCache()
         {
             filteredInstalledPackages = null;
@@ -890,7 +899,9 @@ private void DrawUpdatesHeader()
                     {
                         if (!showDowngrades && GUILayout.Button("Update All", EditorStyles.toolbarButton, GUILayout.Width(100)))
                         {
-                            NugetPackageUpdater.UpdateAll(updatePackages, InstalledPackagesManager.InstalledPackages);
+                            NugetPackageUpdater.UpdateAll(
+                                FilterUpdatableOrDowngradablePackages(updatePackages),
+                                InstalledPackagesManager.InstalledPackages);
                             UpdateInstalledPackages();
                             UpdateUpdatePackages();
                         }