Add device emulation to benchmark-web-vitals
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
changed the title
benchmark-web-vitals
westonruter
commented
Nov 26, 2024
Comment on lines
-453
to
-457
| await page | ||
| .mainFrame() | ||
| .waitForFunction( | ||
| `window.innerWidth === ${ params.windowViewport.width } && window.innerHeight === ${ params.windowViewport.height }` | ||
| ); |
There was a problem hiding this comment.
I removed this code because it with the deviceScaleFactor coming from device emulation, I found the innerWidth and innerHeight to be the viewport's dimensions multiplied by the device scale factor. While I could implement that adjustment, I didn't find that this code was actually necessary.
westonruter
commented
Nov 26, 2024
| @@ -338,7 +357,7 @@ export async function handler( opt ) { | |||
| const params = getParamsFromOptions( opt ); | |||
| const results = []; | |||
|
|
|||
| const browser = await puppeteer.launch( { headless: 'new' } ); | |||
| const browser = await puppeteer.launch( { headless: true } ); | |||
There was a problem hiding this comment.
This change was caught by TypeScript since Puppeteer the new headless mode is now the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #164.
Being able to specify the window dimensions alone is not always sufficient to test a page. In particular, there is also the device scale factor which is often higher on mobile devices. More importantly, if the user agent is not indicating a mobile device then a site may return a page formatted for desktop. This PR introduces a
--emulate-device(-e) parameter to specify one of the known devices in Puppeteer. The--window-viewportarg may still be supplied, and it will override thewidthandheightof the emulated device. If no device is being emulated, then the default viewport remains 960x700.