Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onebot): caching metadata #172

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nullqwertyuiop
Copy link
Contributor

Receiving: tested on Lagrange.Onebot (aa7ca60)

Known Issue:

  1. Selector and ContextClientSelector

    - nick: Nick = await ctx.pull(Nick, ctx.client)
    + nick: Nick = await ctx.pull(Nick, Selector(ctx.client.pattern))

    The type of former is ContextClientSelector while the type of cache keys in context.cache is Selector. When pulling, this line returns None resulting cached metadata not being hit.

  2. Undesired results

    This line should return a non-empty badge running in my environment, but in my testing it returns "". According to OneBot 11 Standard Docs it should work in theory but I'm having no other capable implementations. Further tests may be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant