Charge limit causes bug with Seedvault device backup

[schklom]

How to reproduce

1. Enable the charge limit
2. Plug the phone to charger
3. (Maybe unnecessary) Go to "Backup scheduling" > enable "Back up only when charging"
4. Enable "Backup scheduling"
5. When the scheduled backup happens, the notification "backup failed" happens

Effect

This causes the "backup failed" notification to pop up, and come back whenever it gets dismissed.

Temporary solution

Turn off charge limit, or unplug the phone, or turn off backup scheduling and run backups manually instead.

[thestinger]

Needs to be fixed in Seedvault upstream. We're using the standard Android HAL for this.

[schklom]

Got it, thanks ! I'm not sure if it's better to leave this issue open until Seedvault fixes it, or close it now, so I leave it up to you.
The upstream Seedvault issue is at seedvault-app/seedvault#833

[thestinger]

We're planning on replacing Seedvault with an app using a significantly different approach and don't really want to track the issues here.

[thestinger]

There's a standard Pixel HAL feature for setting the charge to limit just to clarify what is meant by that. We're not setting it with the low-level kernel APIs which are not properly supported by the higher level OS. We considered doing it that way to make it more configurable but it's not the right approach without significant further changes.

[schklom]

I'm updating the relevant issue with your last replies, thanks for the details :)