Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM64 binary and package builds #480

Merged
merged 10 commits into from
Oct 25, 2023
Merged

Add ARM64 binary and package builds #480

merged 10 commits into from
Oct 25, 2023

Conversation

bernd
Copy link
Member

@bernd bernd commented Oct 11, 2023

Fixes #453

@bernd bernd requested a review from mpfz0r October 11, 2023 13:55
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@mpfz0r mpfz0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few nitpicks

bernd and others added 5 commits October 25, 2023 09:40
- Put .PHONY directly in front of the targets
- Add architecture names to each target
- Remove no-op solaris patch download. We switched to elastic/gosigar
  and the patch is installed for cloudfoundry/gosigar.
- Make build less verbose by removing the -v flag from go build
- Make *-all targets more readable
Co-authored-by: Marco Pfatschbacher <[email protected]>
@bernd bernd requested a review from mpfz0r October 25, 2023 07:46
Copy link
Contributor

@mpfz0r mpfz0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bernd bernd marked this pull request as ready for review October 25, 2023 11:56
@bernd bernd merged commit 87d003f into master Oct 25, 2023
1 check passed
@bernd bernd deleted the add/arm64-build branch October 25, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidecar installation in Ubuntu Docker container on macOS ARM
2 participants