Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to the official DataFusion-Substrait implementation #1013

Closed
waynexia opened this issue Feb 15, 2023 · 2 comments · Fixed by #1238
Closed

Migrate to the official DataFusion-Substrait implementation #1013

waynexia opened this issue Feb 15, 2023 · 2 comments · Fixed by #1238
Assignees
@waynexia
Labels
C-enhancement Category Enhancements
Milestone
v0.3

Comments

@waynexia
Copy link
Member

What type of enhancement is this?

Tech debt reduction

What does the enhancement do?

DataFusion has now officially supported Substrait protocol https://docs.rs/datafusion-substrait, we can replace our implementation with this one to gain broader support for plans. This may also help #1010.

We can start to do this after apache/datafusion#5169 is done

Implementation challenges

No response
@waynexia waynexia added the C-enhancement Category Enhancements label Feb 15, 2023
@waynexia waynexia added this to the v0.2 milestone Feb 15, 2023
@waynexia
Copy link
Member Author

waynexia commented Mar 6, 2023

Now that apache/datafusion#5169 has been completed, I'll start work on this.

@fengjiachun fengjiachun moved this to Todo in GreptimeDB v0.2 Mar 12, 2023
@waynexia waynexia mentioned this issue Mar 24, 2023
Merged
@waynexia
Copy link
Member Author

waynexia commented Mar 24, 2023 •
edited
Loading

I tried to migrate in #1238 but found a few blockers apache/datafusion#5717 and apache/datafusion#5716

@killme2008 killme2008 moved this from Todo to In Progress in GreptimeDB v0.2 Mar 25, 2023
@MichaelScofield MichaelScofield mentioned this issue Mar 31, 2023
Closed
@MichaelScofield MichaelScofield pinned this issue Apr 3, 2023
@waynexia waynexia moved this from Todo to In Progress in GreptimeDB cluster M1 Apr 3, 2023
@fengjiachun fengjiachun modified the milestones: v0.2, v0.3 Apr 12, 2023
@waynexia waynexia mentioned this issue Apr 17, 2023
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in GreptimeDB cluster M1 Apr 17, 2023
@waynexia waynexia unpinned this issue Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waynexia waynexia

Labels
C-enhancement Category Enhancements
Projects
GreptimeDB v0.3
Status: Done
GreptimeDB cluster M1
Status: Done
Milestone
v0.3
Development

Successfully merging a pull request may close this issue.

feat: migrate substrait to datafusion official implementation waynexia/greptimedb
2 participants
@fengjiachun @waynexia